Enable support for months and years#1
Merged
onegreyonewhite merged 1 commit intoonegreyonewhite:masterfrom Nov 25, 2021
Merged
Conversation
aa3cd74 to
10dc53e
Compare
Owner
|
Thanks for the suggested fixes. I'll look it on Monday and maybe release new version. I think you add good comment to README which enough for understanding about years and months parameters. |
This was referenced Nov 20, 2021
Owner
|
@amotl thanx for your good contributions! 1.4.0 with this changes released. |
Author
|
Thank you very much, I just converged this into grafana-toolbox/grafanimate#14 - excellent! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Sergey,
first things first: Thanks a stack for what looks like you have been taking over maintenance for this fine package from @wroberts and giving it some love. Cheers!
We are very happy that you listened to the needs of the community and integrated ef62cf1 and 0a71785 already. In the same spirit, we would like to submit a patch which is also of interest to other people and humbly ask for your kindness to integrate it into the code base.
We are aware that this topic has been discussed at wroberts#7 and wroberts#13 already. While the original author was not keen to support it [1], we built upon wroberts#10 by @duramato, submitted wroberts#26 once more [2] and, at the same time, would like to add some energy by sending it to you as well.
With kind regards,
Andreas.
[1]
[2]
/cc @jd, @duramato, @martinb3, @jaraco, @jpopelka, @jhtitor, @Toldry, @hozn.