Skip to content

Comments

Add genetic code nodes#71

Closed
rbaldwin-bugseq wants to merge 3 commits intoonecodex:masterfrom
rbaldwin-bugseq:add_genetic_code_nodes
Closed

Add genetic code nodes#71
rbaldwin-bugseq wants to merge 3 commits intoonecodex:masterfrom
rbaldwin-bugseq:add_genetic_code_nodes

Conversation

@rbaldwin-bugseq
Copy link
Contributor

Added an optional arg to from_ncbi to add genetic_code to TaxonomyNode object

@audy
Copy link
Contributor

audy commented Feb 18, 2026

@rbaldwin-bugseq can you tell me more about the use-case this solves? Accurately regenerating a full NCBI taxdump from a Taxonomy object feels a little out of scope and would require a more changes (E.g., adding more fields, loading non-"scientific name" names.dmp)

@rbaldwin-bugseq
Copy link
Contributor Author

@rbaldwin-bugseq can you tell me more about the use-case this solves? Accurately regenerating a full NCBI taxdump from a Taxonomy object feels a little out of scope and would require a more changes (E.g., adding more fields, loading non-"scientific name" names.dmp)

my issue is that the dmp files output by this lib were not compatible with other bioinformatics software due to missing fields. in my case, it was the genetic code, so i just wanted to add it. Also adding the genebank common name would be useful. What, if anything, can be done to get these attributes added to the TaxonomyNode object ? Thank You.

@audy
Copy link
Contributor

audy commented Feb 19, 2026

@rbaldwin-bugseq having full NCBI taxonomy + metadata support would be generally useful. However, this PR adds only the part needed for a specific downstream tool.

For full support, I think the following is needed:

  1. Support for non-scientific names. This would be really useful (E.g., looking up taxa by synonym)
  2. Support for general metadata about nodes (which could be used to store the genetic code and other NCBI-specific fields)
  3. There are some open questions about interoperability with other formats (E.g., what happens to the other names/metadata when serializing to Newick?)

Closing this as out of scope for now -- full NCBI taxonomy support is something we'd like to tackle more holistically. Happy to revisit as a larger effort.

@audy audy closed this Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants