feat: browser auth bridge impl#31
Conversation
| url: string, | ||
| redirectUri: string | ||
| ): Promise<BrowserSessionResult> { | ||
| console.log('[openAuthSession] called') |
There was a problem hiding this comment.
should the console.logs in this function be gated behind a debug flag or something?
There was a problem hiding this comment.
These are just for debugging/development. They will be removed before beta release
There was a problem hiding this comment.
(this is just a merge into the feature branch - to break up what otherwise would be a 300+ file PR 😅 )
| getDefault (): Promise<Credential | null>; | ||
| setDefault (cred: Credential | null): Promise<void>; | ||
| get tokenStorage (): TokenStorage; | ||
| tokenStorage: TokenStorage; |
There was a problem hiding this comment.
I see this is needed so RN can install its own storage at import time, but that be limited to a one time operation? this allows mutability even after initialization, right
There was a problem hiding this comment.
Correct. This is intentional. JavaScript doesn't have a compiler, therefore any changes to configurations and/or defaults will be performed at runtime
2 participants
No description provided.