chore: bump dependency versions - #187
Open
BenjaminTruong-okta wants to merge 4 commits into
Open
Conversation
…ait-on, etc.), fix stale resolutions, bump Node to 22.18.0
BenjaminTruong-okta
changed the title
BenjaminTruong-okta
marked this pull request as ready for review
August 6, 2026 18:06
| @@ -1,4 +1 @@ | |||
| #!/bin/sh | |||
Contributor
There was a problem hiding this comment.
I think we can just remove husky. I can't find any reference to test:apps:clear - I think this is just leftover from an older approach
The pre-commit hook was inert on fresh clones/CI unless yarn install re-ran the prepare script, and its git-add of test/apps/**/package.json plus the already-dropped test:apps:clear call were leftovers from the old yalc-based test-app linking flow removed in df93feb.
| }, | ||
| "engines": { | ||
| "node": ">=22.16.0", | ||
| "node": ">=22.18.0", |
Contributor
There was a problem hiding this comment.
Can you remove this? This would be considered a breaking change. If you need to specify a specific version of node for building, use https://docs.npmjs.com/cli/v11/configuring-npm/package-json#devengines. engines requires a specific version of node to install the package and therefore could break customer builds
… bump Revert @babel/* in test/e2e to ^7.x; the 7->8 bump was the only thing requiring Node >=22.18.0, and it was not otherwise necessary. Node requirement reverts to >=22.16.0. Also switch root engines to devEngines per review comment, since engines on a published package can break customer installs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-dependency changes
defaulted).
(ESM-only now).
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Reviewers