fix: input validation guards and pack hardening#2
Merged
Conversation
- Reject empty/whitespace entity names on create (kg) - Reject self-loop edges where source_id == target_id (kg) - Add include_deleted flag to get verb for soft-deleted entities (kg) - Expand brain.feedback help to list all 8 signal values (brain) - Validate action verb exists in registry at schedule creation time (schedule) - Return empty list for comm.inbox(limit=0) instead of 1 message (comm) - Add raw_score regression test for tag-filtered recall (memory) - Add get_entity_including_deleted to EntityStore trait (storage/runtime) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Finding 1 (High): schedule verb validation now accepts bare shorthand "remind(...)" in addition to "schedule.remind(...)" by falling back to the prefixed form in describe_verb; error hint updated to show the fully-qualified form. Finding 2 (High): self-loop rejection moved from the single-link handler path into validate_edge_relation_endpoints in the runtime, so atomic bulk and non-atomic bulk link paths are also covered. Existing phantom- self-loop test updated to expect InvalidInput (the runtime fires before NotFound because the UUID check is skipped). Finding 3 (Medium): no code change — include_deleted param description in handler_defs.rs now documents that a full UUID is required when using include_deleted=true (short prefix resolution filters deleted records; the delete response always returns the full UUID). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createsource_id == target_idonlinkinclude_deletedflag togetfor soft-deleted entity inspectionbrain.feedbackhelp text from 3 → 8 signal valuescomm.inbox(limit=0)returning 1 message instead of 0raw_scoreregression test for tag-filteredmemory.recallget_entity_including_deletedto EntityStore trait + runtimeTest plan
create(kind="concept", name="")→"name must not be empty"link(source_id=X, target_id=X)→"self-loop edges are not allowed"get(id=X)after delete → "not found";get(id=X, include_deleted=true)→ returns entity with deleted_atbrain.feedback(help=true)→ lists all 8 signalsschedule.schedule(action="fake_verb()")→ rejectedcomm.inbox(limit=0)→{messages: [], count: 0}🤖 Generated with Claude Code