Skip to content

Fix unsafe template rendering in docker views #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mixinspace wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix unsafe template rendering in docker views #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docker_challenges/assets/view.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{% extends "challenge.html" %}
{% block description %}
{{ challenge.html }}
<div class='mb-3 text-center' id='docker_container' name='{{ challenge.docker_image | safe }}'>
<div class='mb-3 text-center' id='docker_container' name='{{ challenge.docker_image | e }}'>
<span>
<a onclick="start_container('{{ challenge.docker_image | safe }}');" class='btn btn-dark'>
<a onclick='start_container({{ challenge.docker_image | tojson }});' class='btn btn-dark'>
<small style='color:white;'><i class="fas fa-play"></i> Start Docker Instance for challenge</small>
</a>
</span>
Expand Down
6 changes: 3 additions & 3 deletions docker_challenges/templates/admin_docker_status.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ <h1>Docker Status</h1>
<tr id='tr_{{docker.instance_id}}' name='{{docker.id}}'>
<td class='text-left' value='{{docker.id}}'>{{docker.id}}</td>
{% if docker.team_id %}
<td class='text-left' value='{{docker.team_id | safe }}'>{{docker.team_id | safe }}</td>
<td class='text-left' value='{{ docker.team_id | e }}'>{{ docker.team_id | e }}</td>
{% else %}
<td class='text-left' value='{{docker.team_id | safe }}'>{{docker.user_id | safe }}</td>
<td class='text-left' value='{{ docker.user_id | e }}'>{{ docker.user_id | e }}</td>
{% endif %}
<td class='text-left' style="white-space: nowrap;" value='{{docker.docker_image}}'>{{docker.docker_image}}</td>
<td class='text-left' style="white-space: nowrap;" value='{{docker.challenge}}'>{{docker.challenge}}</td>
Expand Down Expand Up @@ -192,4 +192,4 @@ <h3 class='text-center'> No Docker Containers Active</h3>
return obj;
}
</script>
{% endblock scripts %}
{% endblock scripts %}