Skip to content

Use Ember.Copyable mixin features if present #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
offirgolan merged 2 commits into from
Oct 7, 2017
Merged

Use Ember.Copyable mixin features if present #6

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba8f8a4
Use Ember.Copyable mixin features if present
mpirio Aug 19, 2017
d46f91d
Use Ember.canInvoke private method.
mpirio Sep 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions addon/mixins/copyable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,12 +137,21 @@ export default Ember.Mixin.create({
!PRIMITIVE_TYPES.includes(type)
) {
let value = this.get(name);
let transform = getTransform(this, type, _meta);

// Run the transform on the value. This should guarantee that we get
// a new instance.
value = transform.serialize(value, attributeOptions);
value = transform.deserialize(value, attributeOptions);
if (
Copy link
Copy Markdown
Owner

@offirgolan offirgolan Sep 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can just be

if (canInvoke(value, 'copy')) { ... }

Copy link
Copy Markdown
Contributor Author

@mpirio mpirio Sep 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can use Ember.canInvoke. But i would like to be sure value is an Ember Object which extends Ember.Copyable mixin and so, value#copy() is really the method that copy this object (and not a method to do anything else). I do not know how to do... Perhaps do you know?

Copy link
Copy Markdown
Contributor Author

@mpirio mpirio Sep 25, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@offirgolan Any response ? I will make the change but Ember.canInvoke is a private method. We should use Ember.tryInvoke method.

(Ember.typeOf(value) === 'instance') &&
(Ember.typeOf(value.copy) === 'function')
) {
value = value.copy(deep);
Copy link
Copy Markdown
Owner

@offirgolan offirgolan Sep 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment here as to how we can get to this point.

}
else {
let transform = getTransform(this, type, _meta);

// Run the transform on the value. This should guarantee that we get
// a new instance.
value = transform.serialize(value, attributeOptions);
value = transform.deserialize(value, attributeOptions);
}

attrs[name] = value;
} else {
Expand Down