Support for all cyclic messages#15
Conversation
|
As the number of callbacks increases, maybe we should consider other ways to scale this:
The first option requires no user-code changes, the last option requires the most user-code changes. @BrechtSerckx would your real-world use case work well with option 4 or 5? |
7183dad to
f7db784
Compare
As far as I can see, yes. My use-case is very similar to the example code. Small disclaimer: while I find the alternative options interesting, I can't say when I'll have time to work on that, also considering my very limited C++ knowledge. Would it be possible to merge as option 1 and refactor as a follow-up at some point? |
|
Ok yeah it makes sense to segment the refactoring into a separate PR. I'll add a TODO after merging with a link to this conversation. |
This is a fix for #13.
Example program: https://gist.github.com/BrechtSerckx/6d23b859b3192aa284aa145c497aafe5
This will probably break the example program in the library unless #14 is merged in, as currently the callback for
GetBusVIwill intercept explicitly requested messages.