Skip to content

Add deaths_log with gold lost and time dead per death #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
geracosta wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add deaths_log with gold lost and time dead per death #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 71 additions & 3 deletions src/main/java/opendota/CreateParsedDataBlob.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ class PlayerData {
public List<Entry> sen_left_log = new ArrayList<>();
public List<Map<String, Object>> purchase_log = new ArrayList<>();
public List<Map<String, Object>> kills_log = new ArrayList<>();
public List<Map<String, Object>> deaths_log = new ArrayList<>();
public List<Entry> buyback_log = new ArrayList<>();
public List<Map<String, Object>> runes_log = new ArrayList<>();
public List<Entry> connection_log = new ArrayList<>();
Expand Down Expand Up @@ -310,7 +311,7 @@ private void handleArrayField(Entry e, PlayerData player) {
} else if (e.interval != null && e.interval) {
List<Integer> targetList = getPlayerIntegerList(player, e.type);
targetList.add(e.value);
} else if (Arrays.asList("purchase_log", "kills_log", "runes_log", "neutral_tokens_log").contains(e.type)) {
} else if (Arrays.asList("purchase_log", "kills_log", "deaths_log", "runes_log", "neutral_tokens_log").contains(e.type)) {
Map<String, Object> obj = new HashMap<>();
obj.put("time", e.time);
obj.put("key", e.key);
Expand All @@ -327,10 +328,19 @@ private void handleArrayField(Entry e, PlayerData player) {
obj.put("tracked_sourcename", e.tracked_sourcename);
}

if ("deaths_log".equals(e.type)) {
obj.put("gold_lost", e.gold_lost);
if (e.time_dead != null) {
obj.put("time_dead", e.time_dead);
}
}

if ("purchase_log".equals(e.type)) {
player.purchase_log.add(obj);
} else if ("kills_log".equals(e.type)) {
player.kills_log.add(obj);
} else if ("deaths_log".equals(e.type)) {
player.deaths_log.add(obj);
} else if ("runes_log".equals(e.type)) {
player.runes_log.add(obj);
} else if ("neutral_tokens_log".equals(e.type)) {
Expand Down Expand Up @@ -465,19 +475,24 @@ private String computeIllusionString(String input, Boolean isIllusion) {
// window. WK's ult does apply a modifier while reincarnating, at the death
// itself. Both are collected in a pre-scan keyed by event time because the
// chat, modifier and death entries around a reincarnation are not strictly
// ordered in the stream.
// ordered in the stream. The same pass collects the deaths_log lookups:
// gold lost on death (a separate GOLD record, also not ordered against the
// death entry) and the dead stretches, which double as time_dead.
private static final String WK_HERO = "npc_dota_hero_skeleton_king";
private static final String WK_REINCARNATION_MODIFIER = "modifier_skeleton_king_reincarnation";
private static final int AEGIS_EXPIRY_SECONDS = 300;
// Reincarnation revives in ~3s; the shortest real respawn is far longer,
// so a WK back on his feet this fast without a buyback reincarnated
private static final int WK_REVIVE_MAX_SECONDS = 4;
// EDOTA_ModifyGold_Reason: 1 = hero death (the negative bucket in gold_reasons)

@howardchung howardchung Aug 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question around the need to precompute/reorder. I don't think we are doing this for kills_log, so even if it's confusing in some ways it might be better to be consistent?

@geracosta geracosta Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is consistent with kills_log where the two are comparable: the death entry itself ({time, key}) is emitted inline at the death event, same append-in-stream-order pattern as kills_log — no reordering there. The pre-scan only exists to fill the two extra fields, which can't be known at that point in the stream: time_dead is decided by the revive, seconds to minutes later, and gold_lost lives in a separate GOLD combat log record that isn't reliably ordered against the death record (it can land a second or two off by timestamp). kills_log never needs a join like that, so it never needed the maps.

If you'd rather not carry the lookaside maps, dropping gold_lost/time_dead would make this literally kills_log for deaths — but those two fields are the point of #1465 (measuring what the death cost).

private static final int GOLD_REASON_DEATH = 1;

// aegis pickups: slot -> list of {pickupTime, used}
private Map<Integer, List<int[]>> aegisPickupsBySlot = new HashMap<>();
private Map<Integer, List<Integer>> reincarnationTimesBySlot = new HashMap<>();
private Map<Integer, List<int[]>> deadWindowsBySlot = new HashMap<>();
private Map<Integer, List<Integer>> buybackTimesBySlot = new HashMap<>();
private Map<Integer, Map<Integer, Integer>> deathGoldBySlot = new HashMap<>();
private Integer wkSlot = null;

private void precomputeReincarnations(List<Entry> entries, Metadata meta) {
Expand All @@ -500,6 +515,13 @@ private void precomputeReincarnations(List<Entry> entries, Metadata meta) {
}
} else if ("DOTA_COMBATLOG_BUYBACK".equals(e.type) && e.value != null) {
buybackTimesBySlot.computeIfAbsent(e.value, k -> new ArrayList<>()).add(e.time);
} else if ("DOTA_COMBATLOG_GOLD".equals(e.type) && e.gold_reason != null
&& e.gold_reason == GOLD_REASON_DEATH && e.targetname != null && e.value != null) {
Integer slot = meta.hero_to_slot.get(e.targetname);
if (slot != null) {
deathGoldBySlot.computeIfAbsent(slot, k -> new HashMap<>())
.merge(e.time, Math.abs(e.value), Integer::sum);
}
} else if ("interval".equals(e.type) && e.slot != null && e.life_state != null) {
Integer prev = lastState.get(e.slot);
if ((prev == null || prev == 0) && e.life_state != 0) {
Expand All @@ -514,6 +536,8 @@ private void precomputeReincarnations(List<Entry> entries, Metadata meta) {
lastState.put(e.slot, e.life_state);
}
}
// deaths still open when the replay ends stay out of deadWindowsBySlot:
// their length is unknown, so those deaths get no time_dead
}

private boolean consumeReincarnationDeath(Integer slot, Integer time) {
Expand Down Expand Up @@ -571,6 +595,34 @@ private boolean hasBuybackBetween(Integer slot, int from, int to) {
return false;
}

private Integer lookupDeathGold(Integer slot, Integer time) {
Map<Integer, Integer> byTime = slot == null ? null : deathGoldBySlot.get(slot);
if (byTime == null || time == null) {
return 0;
}
for (int dt : new int[] { 0, 1, -1, 2, -2 }) {
Integer v = byTime.remove(time + dt);
if (v != null) {
return v;
}
}
return 0;
}

private Integer lookupTimeDead(Integer slot, Integer time) {
List<int[]> windows = slot == null ? null : deadWindowsBySlot.get(slot);
if (windows == null || time == null) {
return null;
}
for (int[] w : windows) {
// the life_state flip shows up on the tick after the death event
if (w[0] >= time - 1 && w[0] <= time + 3) {
return w[1] - w[0];
}
}
return null;
}

private List<Entry> processExpand(List<Entry> entries, Metadata meta) {
List<Entry> output = new ArrayList<>();
precomputeReincarnations(entries, meta);
Expand Down Expand Up @@ -792,6 +844,22 @@ private void handleDeathCombat(Entry e, List<Entry> output, Metadata meta) {
return;
}

if (e.targethero != null && e.targethero &&
(e.targetillusion == null || !e.targetillusion)) {
// deaths_log includes self-kills (e.g. Techies suicide): the death is
// real (it counts on the scoreboard and loses gold) even though no
// kill is credited below
Entry deathLog = new Entry();
deathLog.time = e.time;
deathLog.unit = key;
deathLog.key = unit;
deathLog.type = "deaths_log";
Integer victimSlot = meta.hero_to_slot.get(key);
deathLog.gold_lost = lookupDeathGold(victimSlot, e.time);
deathLog.time_dead = lookupTimeDead(victimSlot, e.time);
expand(deathLog, output, meta);
}

if (e.attackername != null && e.attackername.equals(key)) {
return;
}
Expand Down Expand Up @@ -1478,7 +1546,7 @@ private void handlePosDataTeamfight(Entry e, TeamfightPlayer player) {
private boolean isArrayField(String type) {
return Arrays.asList("times", "gold_t", "lh_t", "dn_t", "xp_t", "obs_log",
"sen_log", "obs_left_log", "sen_left_log", "purchase_log", "kills_log",
"buyback_log", "runes_log", "connection_log", "neutral_tokens_log",
"deaths_log", "buyback_log", "runes_log", "connection_log", "neutral_tokens_log",
"neutral_item_history").contains(type);
}

Expand Down
3 changes: 3 additions & 0 deletions src/main/java/opendota/Entry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ public class Entry implements Cloneable {
public Boolean interval;
public String event;
public Integer killer;
// deaths_log fields
public Integer gold_lost;
public Integer time_dead;

public Entry() {
}
Expand Down