Technical Training - kymag - 19.0-server-framework-tutorial #1200
Technical Training - kymag - 19.0-server-framework-tutorial #1200
Conversation
|
|
kiro6
changed the title
kiro6
changed the title
lost-odoo
left a comment
lost-odoo
left a comment
There was a problem hiding this comment.
Hello, Good Job 😄! I already made a small review. Feel free to ask me anything if needed.
estate/models/__init__.py
Outdated
| @@ -0,0 +1 @@ | |||
| from . import estate_property No newline at end of file | |||
There was a problem hiding this comment.
Hello do not forget to make the runbot green please 😄
Also github complains when you do not add the final newline ^^
estate/models/estate_property.py
Outdated
|
|
||
|
|
||
| class EstateProperty(models.Model): | ||
| _name = "estate.property" |
There was a problem hiding this comment.
We typically use single quotes for strings, and reserve double quotes for user-facing text.
| _name = "estate.property" | |
| _name = 'estate.property' |
estate/models/estate_property.py
Outdated
|
|
||
| class EstateProperty(models.Model): | ||
| _name = "estate.property" | ||
| _description = "Estate Property model" |
There was a problem hiding this comment.
| _description = "Estate Property model" | |
| _description = 'Estate Property' |
estate/models/estate_property.py
Outdated
| _name = "estate.property" | ||
| _description = "Estate Property model" | ||
|
|
||
| name = fields.Char("Name", required=True) |
There was a problem hiding this comment.
ry to always use keys inside parameters for better readability.
| name = fields.Char("Name", required=True) | |
| name = fields.Char(string="Name", required=True) |
estate/models/estate_property.py
Outdated
| date_availability = fields.Date( | ||
| string="Available From", | ||
| copy=False, | ||
| default=fields.Date.add(fields.Date.today(), days=90), |
There was a problem hiding this comment.
Good but you should use a lambda here as this value is evaluated at server start and does not change unless the server restarts ^^
estate/security/ir.model.access.csv
Outdated
| @@ -0,0 +1,2 @@ | |||
| id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink | |||
| access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1 No newline at end of file | |||
estate/views/estate_menus.xml
Outdated
| <record id="estate_property_action" model="ir.actions.act_window"> | ||
| <field name="name">Properties</field> | ||
| <field name="res_model">estate.property</field> | ||
| <field name="view_mode">list,form</field> | ||
| </record> | ||
|
|
There was a problem hiding this comment.
I am pretty sure this is not the right place where it should be 😄
lost-odoo
left a comment
lost-odoo
left a comment
There was a problem hiding this comment.
God Job! 😄 I have made another review, be careful about the use of double and single quotes ^^
estate/models/estate_property.py
Outdated
| _description = 'Estate Property' | ||
| _order = "id desc" |
There was a problem hiding this comment.
Be careful about your double and single quotes 😄
estate/models/estate_property.py
Outdated
| name = fields.Char("Name", required=True) | ||
| description = fields.Text("description") | ||
| name = fields.Char(string="Name", required=True) | ||
| description = fields.Text(string='Description') |
estate/models/estate_property.py
Outdated
| postcode = fields.Char() | ||
| date_availability = fields.Date( | ||
| string="Available From", | ||
| string='Available From', |
| string="Status", | ||
| default='new' | ||
| ) | ||
|
|
There was a problem hiding this comment.
Useless spacing here ci/style should tell it I think 😄
estate/models/estate_property.py
Outdated
|
|
||
| if float_compare(record.selling_price, limit_price, precision_digits=2) == -1: | ||
| raise ValidationError( | ||
| ("The selling price cannot be lower than 90% of the expected price!" |
There was a problem hiding this comment.
There is a double parenthesis here maybe you are missing the translation function ? (You should use the translation function see: self.env._)
There was a problem hiding this comment.
It’s a way to write the string over two lines without adding an actual \n to the string itself. Since the bot is complaining, I’ll change it.
estate/models/estate_property_tag.py
Outdated
| from odoo import models, fields | ||
|
|
||
|
|
||
| class EstatePropertyType(models.Model): |
There was a problem hiding this comment.
It is not an Estate Property Type but a tag ^^
| <?xml version="1.0" encoding="utf-8"?> | ||
| <odoo> | ||
| <data> | ||
|
|
There was a problem hiding this comment.
Try to avoid adding arbitrary spaces throughout the files 😄
At least I mean in data files 3 empty lines is useless, one line to make it clearer is ok ^^
| <field name="model">estate.property</field> | ||
| <field name="arch" type="xml"> | ||
| <kanban default_group_by="property_type_id" records_draggable="false" > | ||
| <field name="name" /> |
There was a problem hiding this comment.
This can be removed as it is already defined at the bottom
| 'description': """ | ||
| Description text | ||
| """, | ||
| 'application': True, |
There was a problem hiding this comment.
Don't forget the key auto_install as it auto installs the module when all the dependencies are installed.
lost-odoo
left a comment
lost-odoo
left a comment
There was a problem hiding this comment.
God Job! 😄 I have made another review, be careful about the use of double and single quotes ^^
kiro6
force-pushed
the
19.0-server-framework-tutorial-kymag
branch
from
843a124 to
d89fc64
Compare
|
|
kiro6
force-pushed
the
19.0-server-framework-tutorial-kymag
branch
from
88dfc9f to
b73ea4f
Compare
3 participants
No description provided.