[ADD] estate:estate module creation and model implementation.#1194
[ADD] estate:estate module creation and model implementation.#1194habar-odoo wants to merge 12 commits intoodoo:19.0from
Conversation
…ured manifest with required metadata. 2.Covers chapter 2 and 3. 3.Added all the required fields & attributes.
|
|
1) Add missing white spaces after ','. 2) Update parameter String to string. 3) Update manifest file.
1) Add missing white spaces after ','.
bit-odoo
left a comment
bit-odoo
left a comment
There was a problem hiding this comment.
Hello @habar-odoo
Nice work!
I have added some comments.
No need to separate commit for this - 9394ad6, e69355a, bc2d081 , dede429
Can you please follow commit message guidelines?
https://www.odoo.com/documentation/19.0/contributing/development/git_guidelines.html
Thanks
estate/models/estate_property.py
Outdated
| from odoo import models, fields | ||
| from dateutil.relativedelta import relativedelta |
There was a problem hiding this comment.
Can you please follow the coding import guidelines?
https://www.odoo.com/documentation/19.0/contributing/development/coding_guidelines.html#imports
estate/security/ir.model.access.csv
Outdated
| @@ -0,0 +1,2 @@ | |||
| id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink | |||
| access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1 No newline at end of file | |||
There was a problem hiding this comment.
Should be one empty line at the end of the file.
estate/__manifest__.py
Outdated
| 'security/ir.model.access.csv', | ||
| 'views/estate_property_views.xml', | ||
| 'views/estate_menus.xml', | ||
| ], |
estate/models/estate_property.py
Outdated
| ('offerreceived', 'Offer Received'), | ||
| ('offeraccepted', 'Offer Accepted'), |
There was a problem hiding this comment.
| ('offerreceived', 'Offer Received'), | |
| ('offeraccepted', 'Offer Accepted'), | |
| ('offer_received', 'Offer Received'), | |
| ('offer_accepted', 'Offer Accepted'), |
A little bit readable 😅
habar-odoo
force-pushed
the
19.0-tutorials-estate-habar
branch
2 times, most recently
from
0726f45 to
80c5943
Compare
1) Add security file give access rules 2) Update manifest
1) remove trailing space
Create views folder and define actions & menus for the model Declare it in the manifest
1) Create Form view & Search view for the estate model.
habar-odoo
force-pushed
the
19.0-tutorials-estate-habar
branch
2 times, most recently
from
fba649c to
7781522
Compare
bit-odoo
left a comment
bit-odoo
left a comment
There was a problem hiding this comment.
Hello,
Great Work!
Can you please add a description to this commit - 7781522
Also, can you please improve all your commit titles and messages according to the guidelines - https://www.odoo.com/documentation/19.0/contributing/development/git_guidelines.html#
Can you please improve the PR description?
Thanks
| from dateutil.relativedelta import relativedelta | ||
| from odoo import api, fields, models |
There was a problem hiding this comment.
Can you please follow the import coding guidelines?
estate/models/estate_property.py
Outdated
| facades = fields.Integer(string="Facades") | ||
| garage = fields.Boolean(string="Garage") | ||
| garden = fields.Boolean(string="Garden") |
There was a problem hiding this comment.
No need to add a string if your technical name and string name are the same because Odoo is generating the string by default.
| </group> | ||
| </page> | ||
| <page string="Offers"> | ||
| <field name="offer_ids"/> |
| <field name="name">estate.property.list</field> | ||
| <field name="model">estate.property</field> | ||
| <field name="arch" type="xml"> | ||
| <list string="Properties" limit="20"> |
There was a problem hiding this comment.
What is the purpose of adding limit=20?
habar-odoo
force-pushed
the
19.0-tutorials-estate-habar
branch
from
3dfdf02 to
f685be3
Compare
1) create estate property type, estate property tag & estate property offer models. 2) creates relations between them using m2o, m2m & o2m. 3) create views, actions & menus.
1) add total area field set compute method inside. 2) apply logic, used decorator for dependent fields.
1) add best price offers field 2) define logic set computed field
1) Define two fields validity and deadline. 2) Create compute & inverse method for them 3) Also added search functionality in the estate property model for best offers.
habar-odoo
force-pushed
the
19.0-tutorials-estate-habar
branch
from
f685be3 to
41768c1
Compare
1) Define _onchange_garden() to automatically set default garden_area and garden_orientation when the garden is enabled. 2) Clear these fields when the garden is disabled. 3) Add a warning notification when the garden checkbox is checked.
habar-odoo
force-pushed
the
19.0-tutorials-estate-habar
branch
from
d4b4165 to
57fb096
Compare
3 participants
1.Configured manifest with required metadata.
2.Covers chapter 2 and 3.
3.Added all the required fields & attributes.