[ADD] estate : implement estate module by aykhu-odoo · Pull Request #1193 · odoo/tutorials

aykhu-odoo · 2026-03-10T13:50:00Z

Configured manifest with required metadata and dependencies.
It covers chapter- 2 and 3 task
Added the required fields.

robodoo · 2026-03-10T13:50:04Z

bit-odoo

Hello @aykhu-odoo
Good Work!

I have added some comments.

No need do separate commit for - 7285ddd, e8ca15e

Can you please follow commit message guidelines?
https://www.odoo.com/documentation/19.0/contributing/development/git_guidelines.html

Thanks

bit-odoo · 2026-03-16T07:26:00Z

estate/models/estate_property.py

+from odoo import fields, models
+from dateutil.relativedelta import relativedelta


Can you please follow the coding import guidelines?
https://www.odoo.com/documentation/19.0/contributing/development/coding_guidelines.html#imports

bit-odoo · 2026-03-16T07:26:29Z

estate/models/estate_property.py

+        selection=[('north', 'North'),
+                   ('south', 'South'),
+                   ('east', 'East'),
+                   ('west', 'West')],


indentation issue.

bit-odoo · 2026-03-16T07:26:44Z

estate/models/estate_property.py

+        selection=[("New", "New"),
+                   ("Offer Received", "Offer Received"),
+                   ("Offer Accepted", "Offer Accepted"),
+                   ("Sold", "Sold"),
+                   ("Cancelled", "Cancelled")],


Indentation issue.

bit-odoo · 2026-03-16T07:26:56Z

estate/security/ir.model.access.csv

@@ -0,0 +1,2 @@
+id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
+estate.access_estate_property,access_estate_property,estate.model_estate_property,base.group_user,1,1,1,1


Should be one empty line at the end of the file.

bit-odoo · 2026-03-16T07:27:05Z

estate/views/estate_menus.xml

+        <menuitem id = "estate_menu_advertisements_properties" name = "Properties" action="estate_property_action"/>
+    </menuitem>
+</menuitem>          
+</odoo>


Should be one empty line at the end of the file.

bit-odoo · 2026-03-16T07:31:49Z

estate/views/estate_property_views.xml

+            <form>
+                <sheet>
+                    <h1>
+                            <field name="name"/>


Indentation issue.

…tion - Configured manifest with required metadata and dependencies. - It covers chapter- 2 and 3 task - Added the required fields.

- Completed Ch 4 task for Access Rights

- Created an action - Define main menu and submenus - Add views to manifest 'data' list - Completed Ch 5 Action and Menu part

- Added is_active and state fields in form - Added fields in list view - Improved and adjusted fields in Form View - Completed Ch 5 and Ch 6 List and Form Views

- Implemented search view - Added property types, tags, and offers models - Linked properties with buyer, salesperson, types, tags, and offers - Completed Ch 6 and Ch 7.

aykhu-odoo · 2026-03-23T10:14:22Z

Changes Done

bit-odoo

Hello,
Can you please update the tag in the commit message according to these guidelines?
https://www.odoo.com/documentation/19.0/contributing/development/git_guidelines.html#tag-and-module-name

Also, can you please improve your PR title and description?

Thanks

bit-odoo · 2026-03-25T09:08:57Z

estate/models/estate_property.py

+    name = fields.Char(string='Title', required=True, default='Unknown')
+    description = fields.Text(string='Description')
+    postcode = fields.Char(string='Postal Code')
+    last_seen = fields.Datetime(


Can you please tell me the use of this field? Why did you add this field?

bit-odoo · 2026-03-25T09:13:12Z

estate/views/estate_property_views.xml

+<?xml version="1.0" encoding="utf-8"?>
+<odoo>
+    <record id="estate_property_action" model="ir.actions.act_window">
+        <field name="name">Test action</field>


Please use the proper name.

bit-odoo · 2026-03-25T09:18:04Z

estate/models/estate_property.py

+    )
+
+    @api.depends("living_area", "garden_area")
+    def _compute_area(self):


Can you please follow the coding guidelines for the compute method naming?
https://www.odoo.com/documentation/19.0/contributing/development/coding_guidelines.html#symbols-and-conventions

bit-odoo · 2026-03-25T09:19:55Z

estate/views/estate_property_offer_views.xml

@@ -0,0 +1,30 @@
+<?xml version="1.0" encoding="utf-8"?>
+<odoo>
+    <!-- List View-->


These comments are not required here.

bit-odoo · 2026-03-25T09:20:04Z

estate/views/estate_property_offer_views.xml

+        </field>
+    </record>
+
+    <!-- Form View -->


These comments are not required here.

bit-odoo · 2026-03-25T09:23:23Z

estate/views/estate_property_views.xml

+                <field name="living_area"/>
+                <field name="facades"/>
+                <field name="property_type_id"/>
+                <filter name="state" string="Status" domain="['|', ('state', '=', 'New'), ('state', '=', 'Offer Received')]"/>


You can combine these two domains.

- Added Best Offer and Total Area fields in property form view - Covers 2 tasks of chapter 8.

…nction - Added Validity and date_deadline fields with inverse function - Implemented onchange logic for garden_area and garden_orientation - Suggested fixes implemented - Covers last 2 tasks of chapter 8.

aykhu-odoo force-pushed the 19.0-tutorials-estate-aykhu branch from efdc8c4 to abf9768 Compare March 16, 2026 04:35

bit-odoo reviewed Mar 16, 2026

View reviewed changes

aykhu-odoo force-pushed the 19.0-tutorials-estate-aykhu branch from 26297a2 to 5b473b9 Compare March 17, 2026 13:20

aykhu-odoo added 5 commits March 18, 2026 18:56

[ADD] estate : implement estate module and estate_property table crea…

15bd5fa

…tion - Configured manifest with required metadata and dependencies. - It covers chapter- 2 and 3 task - Added the required fields.

[IMP] estate : added access rights

52fa0f3

- Completed Ch 4 task for Access Rights

[ADD] estate: added action and menu

7062c6b

- Created an action - Define main menu and submenus - Add views to manifest 'data' list - Completed Ch 5 Action and Menu part

[IMP] estate: improved list view and form view

5cf7116

- Added is_active and state fields in form - Added fields in list view - Improved and adjusted fields in Form View - Completed Ch 5 and Ch 6 List and Form Views

[ADD] estate: Implemented model relations and search views

a3464a1

- Implemented search view - Added property types, tags, and offers models - Linked properties with buyer, salesperson, types, tags, and offers - Completed Ch 6 and Ch 7.

aykhu-odoo force-pushed the 19.0-tutorials-estate-aykhu branch from 5b473b9 to a3464a1 Compare March 18, 2026 13:34

aykhu-odoo changed the title ~~[ADD] estate : implement estate module and estate_property table creation~~ [ADD] estate : implement estate module Mar 23, 2026

bit-odoo reviewed Mar 25, 2026

View reviewed changes

[IMP] estate: Added computed fields

afff7e1

- Added Best Offer and Total Area fields in property form view - Covers 2 tasks of chapter 8.

aykhu-odoo force-pushed the 19.0-tutorials-estate-aykhu branch 2 times, most recently from d0870ae to 55c78d6 Compare March 27, 2026 13:08

[IMP] estate: Implemented onchange logic and validity with inverse fu…

3426c8b

…nction - Added Validity and date_deadline fields with inverse function - Implemented onchange logic for garden_area and garden_orientation - Suggested fixes implemented - Covers last 2 tasks of chapter 8.

aykhu-odoo force-pushed the 19.0-tutorials-estate-aykhu branch from 55c78d6 to 3426c8b Compare March 27, 2026 13:19

		from odoo import fields, models
		from dateutil.relativedelta import relativedelta

		@@ -0,0 +1,2 @@
		id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
		estate.access_estate_property,access_estate_property,estate.model_estate_property,base.group_user,1,1,1,1 No newline at end of file

Conversation

aykhu-odoo commented Mar 10, 2026

Uh oh!

robodoo commented Mar 10, 2026

Uh oh!

bit-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aykhu-odoo commented Mar 23, 2026

Uh oh!

bit-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants