Draft
Conversation
initial setup of real estate module - Done Basic structure of estate module - Done Estate Property Model Using ORM -Done
|
|
moahi-odoo
force-pushed
the
19.0-tutorials-estate-moahi
branch
from
bea4c23 to
c66d6ed
Compare
Solved Previous Issue Chapter 4 - done Security File Added
moahi-odoo
force-pushed
the
19.0-tutorials-estate-moahi
branch
from
c66d6ed to
002667b
Compare
Views folder created with XML data file Action and Menu added in UI Learned how actions and menus work
Remaining Exercises - Done Added Active fields with Default Value Added State field with their Values
moahi-odoo
force-pushed
the
19.0-tutorials-estate-moahi
branch
from
312f1cb to
8a9ce27
Compare
2 Exercise Solved Added List view to display records Added Form view to display one record in detail
mash-odoo
requested changes
Mar 17, 2026
mash-odoo
left a comment
mash-odoo
left a comment
There was a problem hiding this comment.
Hello!
Great start on the app..
I have added some comments..mostly nits.
Also please update the PR title
moahi-odoo
changed the title
Applied all requested changes Added Search view Added Domain by filter and Group by filter
Completed Exercise 1 ,2 and 3 Added New models, fields, Action and Menus Completed Many2one and Many2many relations
moahi-odoo
force-pushed
the
19.0-tutorials-estate-moahi
branch
2 times, most recently
from
22f5196 to
c78f742
Compare
Completed last Exercise Added New model with their Form and list View Completed One2many relations
moahi-odoo
force-pushed
the
19.0-tutorials-estate-moahi
branch
from
c78f742 to
44870df
Compare
mash-odoo
requested changes
Mar 25, 2026
mash-odoo
left a comment
mash-odoo
left a comment
There was a problem hiding this comment.
Hello!
Good going on the task...
Here are a few questions and suggestions.
| postcode = fields.Char() | ||
| date_availability = fields.Date(string="Available from", copy=False, default=lambda self: fields.Date.today() + timedelta(days=90)) | ||
| expected_price = fields.Float(required=True) | ||
| selling_price = fields.Float(readonly=True, copy=True) |
There was a problem hiding this comment.
Do you know like where should we give readonly?
- While declaring a field in .py file
- While displaying it in UI side
Comment on lines
+9
to
+14
| status = fields.Selection( | ||
| [ | ||
| ('Accepted', "Accepted"), | ||
| ('Refused', "Refused") | ||
| ] | ||
| , copy=False) |
There was a problem hiding this comment.
Suggested change
| status = fields.Selection( | |
| [ | |
| ('Accepted', "Accepted"), | |
| ('Refused', "Refused") | |
| ] | |
| , copy=False) | |
| status = fields.Selection( | |
| [ | |
| ('accepted', "Accepted"), | |
| ('refused', "Refused") | |
| ], | |
| copy=False) |
Try keeping the key in lowercase
Comment on lines
+35
to
+36
| <filter name="available" string="Available" | ||
| domain="['|', ('state', '=', 'new'), ('state', '=', 'offer_received')]"/> |
There was a problem hiding this comment.
Can you rewrite this domain in an optimized way?
| <filter name="available" string="Available" | ||
| domain="['|', ('state', '=', 'new'), ('state', '=', 'offer_received')]"/> | ||
| <filter name="group_postcode" string="Postcode" | ||
| context="{'group_by':'postcode'}"/> |
There was a problem hiding this comment.
Suggested change
| context="{'group_by':'postcode'}"/> | |
| context="{'group_by': 'postcode'}"/> |
Comment on lines
+48
to
+57
| <sheet> | ||
|
|
||
| <h1> | ||
| <field name="name" placeholder="Enter title..."/> | ||
| </h1> | ||
|
|
||
| <group> | ||
| <group> | ||
| <field name="tag_id" widget="many2many_tags"/> | ||
| <field name="postcode"/> |
There was a problem hiding this comment.
Suggested change
| <sheet> | |
| <h1> | |
| <field name="name" placeholder="Enter title..."/> | |
| </h1> | |
| <group> | |
| <group> | |
| <field name="tag_id" widget="many2many_tags"/> | |
| <field name="postcode"/> | |
| <sheet> | |
| <h1> | |
| <field name="name" placeholder="Enter title..."/> | |
| </h1> | |
| <group> | |
| <group> | |
| <field name="tag_id" widget="many2many_tags"/> | |
| <field name="postcode"/> |
Remove unnecessary empty lines from the entire file
| from datetime import timedelta | ||
|
|
||
|
|
||
| class EstateProperty(models.Model): |
There was a problem hiding this comment.
What are the different types of models which we can use?
Also why have you used models.Model here specifically?
|
|
||
| property_type_id = fields.Many2one('estate.property.type', string="Property Type") | ||
| buyer_id = fields.Many2one('res.partner', string="Buyer", copy=False) | ||
| seller_id = fields.Many2one('res.users', string="Seller", default=lambda self: self.env.user) |
There was a problem hiding this comment.
What is a lambda function? And why do we need to use this function here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initial setup of real estate module - Done
Basic structure of estate module - Done
Estate Property Model Using ORM -Done