[IMP] runbot: handle main command exit status#1382
Open
d-fence wants to merge 1 commit into
Open
Conversation
d-fence
force-pushed
the
19.0-handle-exit-status-moc
branch
4 times, most recently
from
6db7e8a to
72d2f2d
Compare
Xavier-Do
reviewed
May 8, 2026
d-fence
force-pushed
the
19.0-handle-exit-status-moc
branch
from
72d2f2d to
785a761
Compare
Since the runbot executes Docker containers non-blockingly, there is no direct way to capture the main command's exit status. With this commit the exit status code of the main command is written to a file. It also adds a new boolean field 'check_exit_status' on ConfigStep that enables checking the exit status. When enabled, the step reads the exit status from the dedicated file and sets the build result to 'ko' if the exit code is non-zero. This allows config steps to properly detect and handle command failures that may not produce error logs but still indicate a failed execution.
d-fence
force-pushed
the
19.0-handle-exit-status-moc
branch
from
785a761 to
3f662cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the runbot executes Docker containers non-blockingly, there is no direct way to capture the main command's exit status.
This commit writes the exit status code to a file at the end of the main Docker command. The feature is now used in Semgrep builds.