[IMP] Add image option to cards, update guidelines#18946
Open
nikibrown wants to merge 1 commit into
Open
Conversation
Collaborator
AntoineVDV
approved these changes
Jul 16, 2026
AntoineVDV
left a comment
Collaborator
There was a problem hiding this comment.
Hi, the diff LGTM from a technical perspective and it doesn't cost much to run and maintain, even if we end up not using images in cards.
Collaborator
There was a problem hiding this comment.
6KB for such a simple image is suspiciously heavy; it can most probably be reduced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary:
Extends the custom Card RST directive to allow for images and alt text based on bootstrap conventions. Added an example in the guidelines and tweaked layout javascript to make card images render correctly.
Task: https://www.odoo.com/odoo/project/3835/tasks/6393116
This 17.0 PR can be FWP up to master.