[IMP] rental: change to physical service product by meval1006 · Pull Request #18943 · odoo/documentation

meval1006 · 2026-07-15T17:39:18Z

What this PR does and why it's needed

Reworks the Rental app's service products documentation to distinguish between physical service products (e.g., hotel rooms, work stations) and non-physical (labor) service products, which now require different configuration steps. The rewrite adds a full walkthrough for setting up a physical service product synced with the Planning app, using a running hotel-room example throughout.

Changes

Service products (Rental)

Retitled service_products.rst to "Physical service rental products" and reframed the intro to explain that physical and labor (non-physical) services require different configurations
Added a new "Configure materials and a role for the physical product" section explaining how to set up a Planning role and materials so shifts sync with the physical product, illustrated with a hotel example (Shady Grove Deluxe Room)
Updated "Create a new service product" to require the Sales and Planning apps, set the Invoicing Policy to Prepaid/Fixed Price, and configure the product's Role page with the Sync Shifts and Rental Orders checkbox
Updated the base rental period/price section with descriptions for the Pickup and Return fields, in addition to Periodicity and Padding Time
Added a new "Set up variants" section showing how to configure product attributes (e.g., bed type, occupancy) for a physical service product
Simplified the pricelist creation guidance and clarified that the Prices tab requires the Pricelists feature to be enabled
Added a tip on adding a Validity date range column to pricelist rules
Added a new "eCommerce features" section describing how the eCommerce tab configures the product's website page
Added six new screenshots illustrating the Planning role/materials setup, the physical service product form, the Role page, and product variants

Rental product types

Added a rental/product_type/configuration anchor to product_type.rst so the Configuration section can be cross-referenced from the service products page

Rental orders

Updated create_rental_order.rst to note that smart-button app integration depends on the service product type, replacing the reference to the removed "properly configured" anchor

This saas-19.3 PR should not be FWP.

robodoo · 2026-07-15T17:39:21Z

meval1006 · 2026-07-15T19:59:28Z

Hi @jero-odoo, this PR is ready to review. I am testing out the Skill.md file to summarize the PR.

jero-odoo

Nice work @meval1006 ! Just a few notes

Co-authored-by: Jess Rogers <104637850+jero-odoo@users.noreply.github.com>

meval1006 · 2026-07-17T18:08:44Z

Hi @erjer-odoo, this review is ready for final review.

erjer-odoo

Sorry there are so many comments; there were just some issues that I noticed while reviewing the file. As soon as you fix them, though, it should be good to go.

@robodoo delegate+

erjer-odoo · 2026-07-17T21:13:58Z

-tours, or booking a studio with a photographer.
+There are two types of service products in the **Rental** app that require different configurations:
+physical and non-physical (labor). This document focuses on the configuration of physical rental
+service products. A physical rental service product is a physical product that doesn’t require any


Suggested change

service products. A physical rental service product is a physical product that doesn’t require any

service products. A physical rental service product is a physical product that doesn't require any

Changing from curly apostrophe to straight apostrophe. This typically happens when copying from a rich-text-based editor to VS Code.

Not sure if you're aware, but VS Code actually highlights these as you draft. I would look out for those apostrophes and change them as you see them.

erjer-odoo · 2026-07-17T21:14:27Z


-.. image:: service_products/rental-settings.png
-   :alt: Sample of Rental app configuration settings.
+To access the Rental app’s settings, navigate to :menuselection:`Rental app --> Configuration -->


Suggested change

To access the Rental app’s settings, navigate to :menuselection:`Rental app --> Configuration -->

To access the Rental app's settings, navigate to :menuselection:`Rental app --> Configuration -->

Same apostrophe issue.

erjer-odoo · 2026-07-17T21:16:08Z


-.. image:: service_products/service-product.png
-   :alt: Sample of a configured service product in the Rental app.
+Click the :icon:`oi-arrow-right` :guilabel:`(Internal link)` icon to open the product’s *Role* page.


Suggested change

Click the :icon:`oi-arrow-right` :guilabel:`(Internal link)` icon to open the product’s *Role* page.

Click the :icon:`oi-arrow-right` :guilabel:`(Internal link)` icon to open the product's *Role* page.

Same apostrophe issue.

erjer-odoo · 2026-07-17T21:22:23Z


-.. image:: service_products/rental-periodicity.png
-   :alt: Sample of the Rental product's Periodicity field in the Sales tab.
+.. _rental/service_products/ additional-pricing:


Suggested change

.. _rental/service_products/ additional-pricing:

.. _rental/service_products/additional-pricing:

Stray space.

erjer-odoo · 2026-07-17T21:22:46Z

+
+Any selected days in the *Unavailability days* section in the :ref:`Rental app's settings
+<rental/product_type/configuration>` are only applied to online booking. If the product isn't
+published to the website then the setting does not go into affect.


Suggested change

published to the website then the setting does not go into affect.

published to the website then the setting does not go into effect.

erjer-odoo · 2026-07-17T21:26:07Z

+  :guilabel:`Periodicity` field and the **Inventory app** is installed.
+- :guilabel:`Pickup`: The earliest time the customer can pick up the product to begin the rental
+  period.
+- :guilabel:`Return:` The latest time the customer can return the product.


Suggested change

- :guilabel:`Return:` The latest time the customer can return the product.

- :guilabel:`Return`: The latest time the customer can return the product.

Seems the colon was misplaced.

erjer-odoo · 2026-07-17T21:27:34Z

+   .. tip::
+      It’s recommended to name the role after the service.


Suggested change

.. tip::

It’s recommended to name the role after the service.

.. tip::

It's recommended to name the role after the service.

Reducing the indent and fixing the rich-text apostrophe issue.

erjer-odoo · 2026-07-17T21:29:11Z

+      .. image:: service_products/plan-services-field.png
+         :alt: Example of the Plan Serviced field configured to the Deluxe Room role.


Suggested change

.. image:: service_products/plan-services-field.png

:alt: Example of the Plan Serviced field configured to the Deluxe Room role.

.. image:: service_products/plan-services-field.png

:alt: Example of the Plan Services field configured to the Deluxe Room role.

Fixing indent and the name of the field.

erjer-odoo · 2026-07-17T21:29:58Z

+   configured.
+
+   .. image:: service_products/example-room-variants.png
+     :alt: Example of the Attribute & Variants tab configured for a hotel room.


Suggested change

:alt: Example of the Attribute & Variants tab configured for a hotel room.

:alt: Example of the Attribute & Variants tab configured for a hotel room.

Indenting the alt tag appropriately.

erjer-odoo · 2026-07-17T21:31:41Z

+.. seealso::
+   - :doc:`../../../services/planning`
+   - :doc:`../../sales/products_prices/prices/pricing`
+


You can delete this extra line at the end of the file -- only one blank line is required.

meval1006 self-assigned this Jul 15, 2026

meval1006 added the 2 label Jul 15, 2026

meval1006 force-pushed the saas-19.3-rental-update-service-products-meval branch from 6d22b8b to ce403cc Compare July 15, 2026 19:57

meval1006 requested a review from jero-odoo July 15, 2026 19:58

meval1006 marked this pull request as ready for review July 15, 2026 19:58

C3POdoo requested a review from a team July 15, 2026 20:00

jero-odoo approved these changes Jul 17, 2026

View reviewed changes

[IMP] rental: change to physical service product

7a1c4f3

Co-authored-by: Jess Rogers <104637850+jero-odoo@users.noreply.github.com>

meval1006 force-pushed the saas-19.3-rental-update-service-products-meval branch from 0e9770c to 7a1c4f3 Compare July 17, 2026 18:07

meval1006 requested a review from erjer-odoo July 17, 2026 18:08

erjer-odoo approved these changes Jul 17, 2026

View reviewed changes

	service products. A physical rental service product is a physical product that doesn’t require any
	service products. A physical rental service product is a physical product that doesn't require any

	To access the Rental app’s settings, navigate to :menuselection:`Rental app --> Configuration -->
	To access the Rental app's settings, navigate to :menuselection:`Rental app --> Configuration -->

	Click the :icon:`oi-arrow-right` :guilabel:`(Internal link)` icon to open the product’s Role page.
	Click the :icon:`oi-arrow-right` :guilabel:`(Internal link)` icon to open the product's Role page.

	.. _rental/service_products/ additional-pricing:
	.. _rental/service_products/additional-pricing:

	published to the website then the setting does not go into affect.
	published to the website then the setting does not go into effect.

	- :guilabel:`Return:` The latest time the customer can return the product.
	- :guilabel:`Return`: The latest time the customer can return the product.

		.. tip::
		It’s recommended to name the role after the service.

		.. image:: service_products/plan-services-field.png
		:alt: Example of the Plan Serviced field configured to the Deluxe Room role.

	:alt: Example of the Attribute & Variants tab configured for a hotel room.
	:alt: Example of the Attribute & Variants tab configured for a hotel room.

Uh oh!

Conversation

meval1006 commented Jul 15, 2026

What this PR does and why it's needed

Changes

Uh oh!

robodoo commented Jul 15, 2026

Uh oh!

meval1006 commented Jul 15, 2026

Uh oh!

jero-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

meval1006 commented Jul 17, 2026

Uh oh!

erjer-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants