[IMP] Purchase: Refining 'Suggested quantities' page#18927
Open
theRealThagomizer wants to merge 1 commit into
Open
[IMP] Purchase: Refining 'Suggested quantities' page#18927theRealThagomizer wants to merge 1 commit into
theRealThagomizer wants to merge 1 commit into
Conversation
Collaborator
|
|
stepperpig
approved these changes
Jul 16, 2026
stepperpig
left a comment
stepperpig
left a comment
Contributor
There was a problem hiding this comment.
Hi @theRealThagomizer, LGTM mostly just had a few suggestions for style and clarity. Otherwise, this is ready for a final check - approved!
Comment on lines
+88
to
+89
| Demand calculation | ||
| ------------------ |
Contributor
There was a problem hiding this comment.
Suggested change
| Demand calculation | |
| ------------------ |
Co-authored-by: Kai Li <stepperpig@gmail.com>
theRealThagomizer
force-pushed
the
19.0-purchases-suggest-quantities-content-refinement-thjud
branch
from
July 16, 2026 22:27
1032c9d to
a51c882
Compare
Contributor
Author
|
Thanks for the review, @stepperpig! @Felicious, this is ready for your review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This 19.0 PR rewrites and reorganizes the "suggest quantities based on historical demand" page. It's pretty straightforward overall.
This 19.0 PR can be FWP up to master.