[FIX] developer/tutorials: Button example without deprecated attrs#18017
Open
Megaaaaaa wants to merge 1 commit into
Open
[FIX] developer/tutorials: Button example without deprecated attrs#18017Megaaaaaa wants to merge 1 commit into
Megaaaaaa wants to merge 1 commit into
Conversation
Collaborator
|
|
Using attrs to make a button invisible is deprecated since 17.0 but the button example hyperlink sends to a commit that used it so it induces people following the tutorial to use attrs which shouldn't be done anymore. This commit replaces the link with the commit that replaced the attrs="" to the plain invisible="" use on the exact same button. (And adjusts the size of the heading delimiter to respect documentation guidelines.)
Megaaaaaa
force-pushed
the
17.0-button_exemple_without_deprecated_attrs-thbe
branch
from
19519ce to
b20dfd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using attrs to make a button invisible is deprecated since 17.0 but the button example hyperlink sends to a commit that used it so it induces people following the tutorial to use attrs which shouldn't be done anymore.
This commit replaces the link with the commit that replaced the
attrs=""to the plaininvisible=""use on the exact same button. (And adjusts the size of the delimiter to respect documentation guidelines.)