[ADD] rental: new product types page#17996
Open
meval1006 wants to merge 1 commit into
Open
Conversation
Collaborator
Contributor
Author
|
Hi @huisit, this PR is ready for review. |
huisit
approved these changes
May 19, 2026
Contributor
huisit
left a comment
There was a problem hiding this comment.
@meval1006 nice addition, it's exciting to watch as you build out this app scope! 💃 I think this is fine to merge as-is, but in future PRs I'd suggest to...
- Cut redundancies: My main suggestion would be to avoid redundancy between the content in this article and:
type.rst: Goods vs. services definitions overlap, consider linking to Goods vs. services section intype.rstinstead of defining them here.- Combo?: And just to confirm since it's listed as a third type there -- are rentals supported for combo products?
rental.rst: Unavailability days config setting is explained in both, consider keeping it one article and linking to it in the other.
- Consider merging with
rental.rst: Depending on how much you do/don't consolidate, consider merging the two. - Update landing: Related to article scope, don't forget to update the landing page! I don't see an open PR for
rental.rst, so in case you don't have a task for it yet, a futurerental.rstPR could:- Add new article cards: Add cards for Rental product type and Create a rental order.
- Un-nest section: Consider making How Minimum Quantity is computed a top-level heading, since there are only four sections.
- Rename Settings → Configuration: Consider renaming to reflect standard article structure.
- Make heading names parallel: Give the three price headings parallel names, e.g. Rental pricing/Rental pricelists/Rental minimums.
- Remove article list: If you add cards for each article, the section lists/TOCs at end of page could be removed.
Co-authored-by: Rex <11528309+huisit@users.noreply.github.com>
aebf664 to
16de014
Compare
Contributor
Author
|
Hi @Felicious, this is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Added the 19.3 version of the Product types page for the Configure products subsection of the Rental app.
Changes
Relevant versions
saas-19.3 to master