Skip to content

[ADD] rental: new product types page#17996

Open
meval1006 wants to merge 1 commit into
saas-19.3from
saas-19.3-rental-new-product-types-page-meval
Open

[ADD] rental: new product types page#17996
meval1006 wants to merge 1 commit into
saas-19.3from
saas-19.3-rental-new-product-types-page-meval

Conversation

@meval1006
Copy link
Copy Markdown
Contributor

Added the 19.3 version of the Product types page for the Configure products subsection of the Rental app.

Changes

  • New page in the Configure products section of the Rental app documentation.
  • New screen shot and revision of text for v 19.3

Relevant versions

saas-19.3 to master

@meval1006 meval1006 requested a review from huisit May 19, 2026 00:55
@meval1006 meval1006 self-assigned this May 19, 2026
@meval1006 meval1006 added the 2 label May 19, 2026
@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented May 19, 2026

Pull request status dashboard

@meval1006
Copy link
Copy Markdown
Contributor Author

Hi @huisit, this PR is ready for review.

@C3POdoo C3POdoo requested a review from a team May 19, 2026 00:57
Copy link
Copy Markdown
Contributor

@huisit huisit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meval1006 nice addition, it's exciting to watch as you build out this app scope! 💃 I think this is fine to merge as-is, but in future PRs I'd suggest to...

  1. Cut redundancies: My main suggestion would be to avoid redundancy between the content in this article and:
    • type.rst : Goods vs. services definitions overlap, consider linking to Goods vs. services section in type.rst instead of defining them here.
      • Combo?: And just to confirm since it's listed as a third type there -- are rentals supported for combo products?
    • rental.rst: Unavailability days config setting is explained in both, consider keeping it one article and linking to it in the other.
  2. Consider merging with rental.rst: Depending on how much you do/don't consolidate, consider merging the two.
  3. Update landing: Related to article scope, don't forget to update the landing page! I don't see an open PR for rental.rst, so in case you don't have a task for it yet, a future rental.rst PR could:
    • Add new article cards: Add cards for Rental product type and Create a rental order.
    • Un-nest section: Consider making How Minimum Quantity is computed a top-level heading, since there are only four sections.
    • Rename SettingsConfiguration: Consider renaming to reflect standard article structure.
    • Make heading names parallel: Give the three price headings parallel names, e.g. Rental pricing/Rental pricelists/Rental minimums.
    • Remove article list: If you add cards for each article, the section lists/TOCs at end of page could be removed.

Comment thread content/applications/sales/rental/configure_products/product_type.rst Outdated
Comment thread content/applications/sales/rental/configure_products/product_type.rst Outdated
Comment thread content/applications/sales/rental/configure_products/product_type.rst Outdated
Comment thread content/applications/sales/rental/configure_products/product_type.rst Outdated
Comment thread content/applications/sales/rental/configure_products/product_type.rst Outdated
Co-authored-by: Rex <11528309+huisit@users.noreply.github.com>
@meval1006 meval1006 force-pushed the saas-19.3-rental-new-product-types-page-meval branch from aebf664 to 16de014 Compare May 19, 2026 22:43
@meval1006 meval1006 requested a review from Felicious May 19, 2026 22:43
@meval1006
Copy link
Copy Markdown
Contributor Author

Hi @Felicious, this is ready for review.

@C3POdoo C3POdoo requested a review from a team May 19, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants