[IMP] timeoff: update accrual custom date#5147
Open
yogietama wants to merge 1 commit into
Open
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding-yomet, it needs to be retargeted before it can be merged. |
yogietama
force-pushed
the
master-hr-accrual_ux-yomet
branch
9 times, most recently
from
75dc6c2 to
b0bbfa2
Compare
mepe-odoo
requested changes
May 11, 2026
There was a problem hiding this comment.
Hello this behavior was already worked in the backend; this task is only a frontend task :)
Author
There was a problem hiding this comment.
Alright, so it only need to handle it in front end. thank you. updated
Comment on lines
+22
to
+28
| let dayList = []; | ||
| for (let i = 1; i <= maxDays; i++) { | ||
| const val = i.toString() | ||
| dayList.push([val, val]); | ||
| } | ||
|
|
||
| return dayList; |
There was a problem hiding this comment.
no need to create a new dayList you can use the super to retrieve this list and after filter it :)
There was a problem hiding this comment.
don't forget the empty line at the end of the file :)
Comment on lines
+198
to
+199
| <!-- <field name="carryover_day" widget="day_selection" month_field="carryover_month" placeholder="select a day" | ||
| required="carryover_date == 'other'"/> --> |
There was a problem hiding this comment.
please clean all the commented code :)
This restrict selection date according of the month selected and current year task:5364831
yogietama
force-pushed
the
master-hr-accrual_ux-yomet
branch
from
b0bbfa2 to
ef7ae98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restrict selection date according of the month selected and current year
task:5364831