Merged
Conversation
dra27
force-pushed
the
msvc-overlays
branch
2 times, most recently
from
13f1e38 to
3156d02
Compare
Contributor
Author
|
This is presently pushed live and appears to be working! Cygwin setup has already been patched, but the change is actually worth forcing anyway (at least while we still use cygsympathy). |
Contributor
Author
|
This now depends on ocurrent/ocaml-dockerfile#80. |
MisterDA
approved these changes
Jan 7, 2022
Contributor
Author
|
@talex5 / @tmcgilchrist - any objections to the mechanism used here for doing (i.e. having an extra repo which gets selectively added?). It's kernel update day on Wednesday morning, so it'd be nice (though not compulsory) to have this merged before then. |
talex5
reviewed
Jan 10, 2022
Contributor
talex5
left a comment
talex5
left a comment
There was a problem hiding this comment.
Having an extra overlay on Windows seems fine to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is WIP - opening with a trial version to test the fix.(loosely) related to ocurrent/ocaml-dockerfile#79The Visual Studio images haven't been building for months for 4.10, 4.12 and 4.13 owing to the need for either ocaml/ocaml#10797 or ocaml/flexdll#96. This PR opts for the latter by upgrading the embedded flexdll in opam-repository-mingw to 0.40 (which includes that PR).
I've done this by creating a ocurrent/opam-repository-mingw which houses the patch in the patches branch and has a tiny opam repo in the overlay branch containing just the patched opam files.
I don't expect those compiler packages to change in upstream opam-repository-mingw before ocaml-base-compiler gains Windows support in ocaml/opam-repository later this year, but the patches can of course be updated as necessary.