Extends Config/Plugin for Deno packaging#504
Open
AndresPrez wants to merge 4 commits intooclif:mainfrom
Open
Conversation
|
Thanks for the contribution! Before we can merge this, we need @AndresPrez to sign the Salesforce.com Contributor License Agreement. |
AndresPrez
changed the title
mdonnalley
added
waiting for interest
rektide
reviewed
Mar 17, 2024
| export function loadJSON(_path: string): Promise<any> { | ||
| debug('config')('loadJSON %s', path) | ||
| // Allows reading JSON with comments | ||
| const _JSON = path.extname(_path) === '.jsonc' ? JSON5 : JSON |
There was a problem hiding this comment.
thinking out loud here, maybe using dynamic imports here (so json5 isn't loaded by json users) might be kind.
Author
There was a problem hiding this comment.
Sure, although it seems salesforce ppl have lost interest in supporting Deno
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tackles the
oclif/corepart for #503.It paves the way to start supporting deno projects. It essentially extends the logic around using the
package.jsonas the project's root config file to also support Deno'sdeno.jsoncconfiguration file.