chore: add support for others token decimals that are not 18#2024
Merged
AdriGeorge merged 14 commits intomainfrom Jan 21, 2026
Merged
chore: add support for others token decimals that are not 18#2024AdriGeorge merged 14 commits intomainfrom
AdriGeorge merged 14 commits intomainfrom
Conversation
AdriGeorge
requested review from
alexcos20,
andreip136,
bogdanfazakas,
dnsi0,
giurgiur99,
mihaisc and
ndrpp
as code owners
Member
|
We should detect the number of decimals for a token, not hardcode them. |
Member
|
think a test that uses a token with 6 decimals would be useful besides this looks good to me |
4 tasks
chore: test deposit withdraw token 6 decimals
Revert "chore: test deposit withdraw token 6 decimals"
Member
|
let's merge it and handle remaining issues in another pr |
alexcos20
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Changes proposed in this PR: