Remove table API from seekdb#855
Open
hnwyllmm wants to merge 5 commits into
Open
Conversation
Delete src/observer/table/ (~250 files) - KV/HKV/Redis/HBase/Table API Delete src/libtable/ (~32 files) - client SDK Delete src/observer/table_load/client/ (~4 files) - table_api RPC entry Delete share/table/ redis/ + ob_table.* + ob_table_rpc_* (~20 files) Delete all table_api test files (~45 files) Fix cross-module references - Stub out KV virtual tables, TTL RPC handler - Remove table_api MTL registrations, RPC processors - Add missing includes for transitive dependencies - Keep table_load/ (used by SQL LOAD DATA path) - Keep share/table/ ob_ttl_util, ob_table_ddl_struct, ob_table_config_util, ob_table_load_* files (used by other modules) Total: ~351 files deleted, ~144,920 lines removed Build: verified (seekdb binary generated)
- Remove ObRedisHelper, ObRedisInfoV1, ObKvModeType dead types - Remove import_redis_info/check_redis_info/check_basic_info (REDIS-only) - Simplify ObRedisImporter::exec_op to return OB_NOT_SUPPORTED - Remove ObTTLUtil::check_is_htable_ttl_ and clean up callers - Remove ObRedisDataModel enum and redis_model_ field from ObKVAttr - Remove check_kv_attributes and check_htable_ddl_supported - Fix 13 external callers in sql/resolver/ddl/ and rootserver/ - Remove empty is_user_ls branches in ob_ls.cpp - Add missing include for ob_alter_system_executor.cpp Build: verified
Previously hosted inside ObTenantTabletTTLMgr (deleted with table_api). Decoupled and added directly as ObLS member with full lifecycle - init + REGISTER_TO_LOGSERVICE in register_to_service_ - stop in stop_ - wait TG_WAIT in wait_ - safe_to_destroy check - UNREGISTER + destroy + TG_DESTROY in unregister_user_service_ Build: verified
Delete ObAllVirtualKvConnection, ObAllVirtualKvClientInfo ObAllVirtualKvGroupCommitInfo - all empty stubs with no functionality. Build: verified
Member
Author
|
The mapping Dima issue is Deleting TABLE API code. |
Member
Author
Member
Author
|
Core Test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task Description
Remove table API from seekdb.
Solution Description
Passed Regressions
Upgrade Compatibility
Other Information
Release Note