Skip to content

Avoid NeoVim error when opening .mll files#1557

Merged
voodoos merged 2 commits intoocaml:masterfrom
edwintorok:fix-mll-error
Oct 3, 2025
Merged

Avoid NeoVim error when opening .mll files#1557
voodoos merged 2 commits intoocaml:masterfrom
edwintorok:fix-mll-error

Conversation

@edwintorok
Copy link
Copy Markdown
Contributor

@edwintorok edwintorok commented Sep 20, 2025

Opening a .mll file results in:
ocamllsp: -32600: unsuppported file extension

There is still an error because NeoVim sends the wrong language ID (ocaml instead of ocaml.ocamllex)
(which ocaml/vim-ocaml#61 is trying to fix), but at least with this change there is one less error.
The remaining error can be fixed by ocaml/ocaml.org#3322 (comment) (workaround), or ocaml/vim-ocaml#61 (+ its NeoVim equivalent), and is not something the LSP server should fix.

Opening a .mll file results in:
`ocamllsp: -32600: unsuppported file extension`

Signed-off-by: Edwin Török <edwin@etorok.net>
Signed-off-by: Edwin Török <edwin@etorok.net>
Copy link
Copy Markdown
Collaborator

@voodoos voodoos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonnable to me, thank you @edwintorok

@voodoos voodoos merged commit 8c788a7 into ocaml:master Oct 3, 2025
6 checks passed
davesnx added a commit to davesnx/ocaml-lsp that referenced this pull request Oct 3, 2025
…rmat-mlx

* 'master' of github.com:/ocaml/ocaml-lsp:
  Avoid NeoVim error when opening .mll files (ocaml#1557)
  Fix hover on method calls (ocaml#1553)
voodoos added a commit to voodoos/opam-repository that referenced this pull request Oct 3, 2025
CHANGES:

## Fixes

- Fix hover on method calls not showing the type. (ocaml/ocaml-lsp#1553, fixes ocaml/ocaml-lsp#1552)
- Fix error on opening `.mll` files (ocaml/ocaml-lsp#1557)
- Ensure compatibility with both yojson 2.0 and 3.0. (ocaml/ocaml-lsp#1534)
voodoos added a commit to voodoos/opam-repository that referenced this pull request Oct 3, 2025
CHANGES:

## Fixes

- Fix hover on method calls not showing the type. (ocaml/ocaml-lsp#1553, fixes ocaml/ocaml-lsp#1552)
- Fix error on opening `.mll` files (ocaml/ocaml-lsp#1557)
- Ensure compatibility with both yojson 2.0 and 3.0. (ocaml/ocaml-lsp#1534)
davesnx pushed a commit to davesnx/ocaml-lsp that referenced this pull request Nov 26, 2025
* Avoid NeoVim error when opening .mll files

Opening a .mll file results in:
`ocamllsp: -32600: unsuppported file extension`

Signed-off-by: Edwin Török <edwin@etorok.net>

* Add Changes entry

Signed-off-by: Edwin Török <edwin@etorok.net>

---------

Signed-off-by: Edwin Török <edwin@etorok.net>
davesnx pushed a commit to davesnx/ocaml-lsp that referenced this pull request Nov 26, 2025
* Avoid NeoVim error when opening .mll files

Opening a .mll file results in:
`ocamllsp: -32600: unsuppported file extension`

Signed-off-by: Edwin Török <edwin@etorok.net>

* Add Changes entry

Signed-off-by: Edwin Török <edwin@etorok.net>

---------

Signed-off-by: Edwin Török <edwin@etorok.net>
Tim-ats-d pushed a commit to Tim-ats-d/ocaml-lsp that referenced this pull request Mar 5, 2026
* Avoid NeoVim error when opening .mll files

Opening a .mll file results in:
`ocamllsp: -32600: unsuppported file extension`

Signed-off-by: Edwin Török <edwin@etorok.net>

* Add Changes entry

Signed-off-by: Edwin Török <edwin@etorok.net>

---------

Signed-off-by: Edwin Török <edwin@etorok.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants