Fix event SourceFilterSettingsChanged not firing#1346
Open
ruggi99 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #1303. I've added subscription to
updateevent for filtersMotivation and Context
This issue exists because filters are private by design.
https://github.com/obsproject/obs-studio/blob/30d3b89b3bd02c40ca55d071b2fd038a1c40caa6/libobs/obs-source.c#L436-L460
And, always by design, global/core signals are not fired for private sources
https://github.com/obsproject/obs-studio/blob/30d3b89b3bd02c40ca55d071b2fd038a1c40caa6/libobs/obs-internal.h#L1031-L1042
The solution is to subscribe to source(filter)'s signal
updatein order to fire the correspondingSourceFilterSettingsChangedevent on websocketHow Has This Been Tested?
This PR has not been tested yet. I don't have knowledge to compile this code, only to understading a little bit.
Will test the artifact produced by CI
Types of changes
Checklist:
masteror arelease/*branch.