Update to C++20#517
Conversation
RytoEX
left a comment
There was a problem hiding this comment.
Super nit, but looks fine otherwise.
PatTheMav
left a comment
There was a problem hiding this comment.
I'm on board with increasing the language level to C++20, however that change should affect all targets (and not just the Linux ones).
obs-browser is not a "standalone module" (I removed CMake code to that end IIRC) and thus should always inherit what the main project sets up as (via CMAKE_CXX_STANDARD).
And moving the project to C++20 is indeed in the works already, so the issue will be solved automatically through that.
|
FWIW this patch is needed to build OBS with current CEF today. I'm not a CMake nor C++ expert, but building just the browser bits as C++20 (which is what this PR does) seems to work fine (and this patch is what Fedora is shipping). |
Current CEF requires compiling as C++20.
Description
Current CEF requires compiling as C++20.
Motivation and Context
Fails to build with CEF 145.
How Has This Been Tested?
Tested as local build, testing in Fedora shortly.
Types of changes
Checklist: