-
Notifications
You must be signed in to change notification settings - Fork 37
checks: Check for game captures needing admin #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
6b1db8e to
66c0d05
Compare
66c0d05 to
108dfb2
Compare
108dfb2 to
cd6d889
Compare
|
I need to mull over the verbiage here, but conceptually this seems fine. I just want to be sure that it's clear admin may not resolve the issue and there might be something else going on. I thought we had a list of known games that do require admin rights, but I suppose this message is very unlikely to show up otherwise, so it's probably fine. EDIT: for reference: https://github.com/obsproject/obs-studio/blob/master/plugins/win-capture/data/compatibility.json |
|
For the wording, I could add a link to the Game capture troubleshooting page on the KB? |
|
I think that's a good idea, yeah. Something like:
|
cd6d889 to
6072c1e
Compare
|
Thoughts on the new verbiage? |
|
I still prefer my original suggestion, though maybe with a slight tweak:
|
Description
Some games require OBS to be run as admin for game capture to capture them properly, usually because they themselves are running as admin.
This usually manifests in the log with the line
[game-capture: '<source name>'] could not open process: <executable>This PR leverages this to present the user with a message informing them that running obs as admin might be needed.
To be noted, I have hesitations and would like feedback on two points of its presentation, namely, the title of the factoid, and whether listing the executables would really be useful to the user.
Motivation and Context
"Game capture no work" is not only one of the most common issues in windows support, it is also a quite obscure one. There are multiple potential causes for it, which are indistinguishable without reading the log file with special knowledge of it.
This would allow to lift this obscurity to end users on one of the possible causes.
How Has This Been Tested?
Running locally with https://obsproject.com/logs/1EHNwuIInbVRKWxI, as well as a modified version of it to check for behaviour in case of multiple executable.
Types of changes
Checklist: