Skip to content

Conversation

@simonpasquier
Copy link
Contributor

No description provided.

squat
squat previously approved these changes Dec 22, 2025
@simonpasquier simonpasquier force-pushed the update-e2e-services branch 2 times, most recently from 7a3d6c2 to 0568b3e Compare December 24, 2025 09:37
@simonpasquier
Copy link
Contributor Author

@pavolloffay I'd need your insights because the TestTracesTempo test fails with:

=== NAME  TestTracesTempo/write-then-query-single-trace
    traces_test.go:609: �[31mhelpers.go:127: "failed to assert that the response '{"batches":[{"resource":{"attributes":[{"key":"service.name","value":{"stringValue":"my.service"}}]},"scopeSpans":[{"scope":{"name":"my.library","version":"1.0.0","attributes":[{"key":"my.scope.attribute","value":{"stringValue":"some scope attribute"}}]},"spans":[{"traceId":"W47/95gDgQPSabYzgT/GDA==","spanId":"7uGbfsPBsXQ=","parentSpanId":"7uGbfsPBsXM=","name":"I'm a server span","kind":"SPAN_KIND_SERVER","startTimeUnixNano":"1544712660000000000","endTimeUnixNano":"1544712661000000000","attributes":[{"key":"my.span.attr","value":{"stringValue":"some value"}}],"status":{}}]}]}]}' contains '{"batches":[{"resource":{"attributes":[{"key":"service.name","value":{"stringValue":"my.service"}}]},"scopeSpans":[{"scope":{"name":"my.library","version":"1.0.0"},"spans":[{"traceId":"W47/95gDgQPSabYzgT/GDA==","spanId":"7uGbfsPBsXQ=","parentSpanId":"7uGbfsPBsXM=","name":"I'm a server span","kind":"SPAN_KIND_SERVER","startTimeUnixNano":"1544712660000000000","endTime...(output trimmed)"�[39m

Debugging locally I can see that the difference between the returned and expected traces is around the scope attributes.

The returned trace has:

...
          "scope": {
            "name": "my.library",
            "version": "1.0.0",
            "attributes": [
              {
                "key": "my.scope.attribute",
                "value": {
                  "stringValue": "some scope attribute"
                }
              }
            ]
          },
...

while the test expects no scope attributes

@pavolloffay
Copy link
Member

pavolloffay commented Jan 14, 2026

Probably due to grafana/tempo#3649 added in https://github.com/grafana/tempo/blob/main/CHANGELOG.md#v250

They added support for scope attributes. The expected assert should be updated.

This commit updates backend services:
* Alertmanager to v0.30.1
* Thanos to v0.40.1
* Loki to v2.9.17
* Tempo to v2.9.0

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@simonpasquier
Copy link
Contributor Author

the test job failure is unrelated I believe.

@simonpasquier
Copy link
Contributor Author

cc @philipgough

@philipgough philipgough merged commit ad02ec7 into observatorium:main Jan 15, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants