chore(studio): remove dead code left by the package spec-form migration - #2540
Merged
Conversation
After #2535 replaced the three hand-rolled package forms with the spec-driven PackageFormDialog, several helpers and i18n keys are no longer referenced: - packages-io.createBasePackage (the old landing/switcher create path); - PackageIdInput's PackageIdSuggestionHint (name→id suggestion for the old landing create form) + its test block; - 10 now-unused i18n keys (× en/zh): the old create-form id/namespace validation messages and name/id/namespace placeholders. PackageIdInput itself stays — the landing "duplicate package" form still uses it (and its idStripped/idFormat hints). No behaviour change; type-check + the affected tests pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up cleanup to #2535, which replaced the three hand-rolled package forms with the spec-driven
PackageFormDialog. These are now unreferenced in production:packages-io.createBasePackage— the old landing/switcher create path (create now POSTs the manifest straight fromPackageFormDialog).PackageIdSuggestionHint(inPackageIdInput.tsx) + its test — the name→id suggestion hint for the old landing create form.PackageIdInputitself stays — the landing "duplicate package" form still uses it, along with itsidStripped/idFormathint keys.No behaviour change. Verified each removed symbol/key has zero production references; type-check clean and the affected tests (PackageIdInput, PackageFormDialog, EditPackageDialog, CreatePackageDialog.namespace — 15 tests) pass.
🤖 Generated with Claude Code