feat(app-shell): book audience gates by permission set — mirror the spec's { permissionSet } shape (ADR-0090)#2371
Merged
Conversation
…pec's { permissionSet } shape (ADR-0090)
The framework retired BookAudience's { profile } arm (ADR-0090 D2 removed
the Profile concept; D9 makes the gate a capability reference). Update the
three UI mirrors: the metadata-admin default JSON schema oneOf, the
BookPreview audience chip, and the book list-column renderer. The "Role-
gated" form title also violated the D3 word ban and is now
"Permission-set gated".
Companion to objectstack-ai/objectstack#2732.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ph4jEAfWDh6taMbZweWhom
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
os-zhuang
marked this pull request as ready for review
July 10, 2026 04:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to objectstack-ai/objectstack#2732, which retires
BookAudience's{ profile: string }arm — the Profile concept was removed by ADR-0090 D2, and per D9 the gate becomes a capability reference:{ permissionSet: string }, e.g.{ permissionSet: 'crm_admin' }(packages own permission sets but never positions, so a permission-set gate keeps ADR-0086 provenance/uninstall semantics intact). Launch-window one-step rename, no alias.Changes
Three UI mirrors of the shape updated in
@object-ui/app-shell:views/metadata-admin/default-schemas.ts— thebook.audienceJSON-schemaoneOfobject arm is now{ permissionSet }; the form title "Role-gated" (itself a violation of the ADR-0090 D3 word ban in UI copy) becomes "Permission-set gated".views/metadata-admin/previews/BookPreview.tsx— the audience chip type and renderer readpermissionSetand label it "Permission set: …".services/builtinComponents.tsx— the book list's Audience column renderspermission set: ….Plus a
minorchangeset for@object-ui/app-shell.Not in this PR (flagged for follow-up)
default-schemas.tsstill carries two other pre-ADR-0090 leftovers: arolemetadata-type schema (withparentRolehierarchy — positions are flat per D3) and aprofiletype schema (withisProfile, removed by D2). These mirror the framework'smetadata-form-registry.ts, which still mapsprofile: permissionForm, so removing them cleanly needs a coordinated registry change rather than a drive-by edit here.🤖 Generated with Claude Code
https://claude.ai/code/session_01Ph4jEAfWDh6taMbZweWhom
Generated by Claude Code