feat(showcase): nav separator + badge specimens; correct the §3 item-8 verdict (#1878) - #3694
Merged
Merged
Conversation
…8 verdict (#1878) Adds the two nav-affordance specimens to the showcase Analytics group (`nav_sep_reports` separator + `badge: 'NEW'`/`badgeVariant: 'secondary'` on Hours by Status) and corrects the naming-drift recheck, which twice published a wrong verdict for this item. The keys are LIVE. UnifiedSidebar delegates the whole app-navigation tree to NavigationRenderer (UnifiedSidebar.tsx:437), which implements separator (:906) and badge/badgeVariant (:983-985); processedNavigation only reorders and pins, spreading every other key through. Browser-verified against an UNMODIFIED objectui checkout: the divider draws and the NEW pill renders. No objectui change was needed -- the port this PR was originally going to make would have duplicated existing capability. Both wrong rounds shared one shape: a strong negative claim ("the component was deleted", "nobody imports it") resting on a search whose results were silently truncated (head -3) or filtered (a pathspec glob that never matched the nested path). The doc now carries a methodology note: a grep can only prove presence; for "does authoring this key do anything", author it and look. Showcase suite 58/58 green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3677. This PR retracts a claim that PR and its merged doc made — and adds the specimen that settles it.
The correction
#3677's recheck said app
badge/badgeVariant+ navseparatorwere unconsumed by the console sidebar, and recommended porting three render branches intoUnifiedSidebar. That was wrong. The keys are live:NavigationRendererimplements them (:906separator,:983-985badge)UnifiedSidebardelegates the whole app-navigation tree to it —UnifiedSidebar.tsx:437, passingprocessedNavigation, which only re-orders/pins and spreads every other key throughBrowser-verified against an unmodified objectui checkout: with the specimen below, the divider draws and the
NEWpill renders. The port this PR was originally scoped to do would have duplicated existing capability.Changes
nav_sep_reports(separator) +badge: 'NEW'/badgeVariant: 'secondary'on Hours by Status, in the Analytics group. Same rationale as the report-chart andshowcase_archive_taskspecimens: a live key with no first-party usage rots invisibly.2026-07-naming-drift-recheck.md: item 8 → ALIGNED; disposition rewritten; plus a methodology note on how the item was got wrong twice.audits/README.md§3 annotation corrected accordingly.How it was got wrong (recorded in the doc)
git grep -rln NavigationRenderer | head -3→ 3 CHANGELOG hitshead -3truncated the source hitgit grep -n NavigationRenderer -- 'packages/*/src'→ emptypackages/app-shell/src/layout/…Both bad rounds share one shape: a strong negative claim resting on a search whose result set was silently truncated or filtered. A grep can only prove presence; absence needs an exhaustive search you have verified is exhaustive — or, decisively, a runtime observation. For liveness questions specifically, authoring the key and looking is usually cheaper and sound.
Showcase suite 58/58 green.
Refs #1878, #3677, #3685, #3686.
🤖 Generated with Claude Code