feat(spec)!: remove the orphaned FeatureFlagSchema module (kernel/feature.zod) - #3630
Merged
Conversation
…ture.zod) Follow-through of #3605: kernel/feature.zod.ts (FeatureStrategy, FeatureFlagSchema, the FeatureFlag factory + types) had zero runtime consumers, and its only protocol home — the static ObjectStackCapabilities.system.features descriptor — was itself removed as dead in #3605. Not authorable (defineStack has no features key), not registered, not read by any engine. Live toggles are the feature_flags settings manifest (ADR-0007, OS_FEATURE_FLAGS_*) and the PUBLIC_AUTH_FEATURES registry for auth gates. - Delete feature.zod.ts + feature.test.ts; kernel/index export dropped with a removal note; manifest keys kernel/FeatureFlag + kernel/FeatureStrategy dropped; PROTOCOL_MAP row dropped; SKILL_MAP entry dropped (skill refs regenerated). - Docs: references/kernel/feature.mdx removed by regen; the hand-written quick-reference row removed; the platform skill's Feature Flags section rewritten to point at the settings surface; public-auth-features.ts "not to be confused" comment updated. - api-surface: 4 exports, pure removal. Changeset (minor) carries the removed-shape → settings-manifest migration table. Verified: 6663 spec tests green, tsc clean, check:docs/api-surface/ skill-refs/skill-docs/react-blocks/skill-examples all in sync, downstream-contract typecheck clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
documentation
Contributor
📓 Docs Drift CheckThis PR changes 2 package(s): 105 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
…he ADR-0058 ledger The expression-conformance ledger's cel-formula entry covered kernel/feature.zod.ts:expression — the surface vanished with the orphaned FeatureFlagSchema module, so the ADR-0060 checkLedger STALE-covers gate correctly failed Dogfood shard 2/2. Caught by the ledger, not by symbol grep: the entry references the file PATH, not the FeatureFlag symbol. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-through of the capabilities-descriptor prune (#3605), which left
kernel/feature.zod.tsa confirmed orphan. Umbrella #1878 family.Why
FeatureStrategy/FeatureFlagSchema/ theFeatureFlagfactory had zero runtime consumers, and their only protocol home — the staticObjectStackCapabilities.system.featuresdescriptor — was itself removed as dead in #3605 (no endpoint ever served it). The module was a compile-checkable shape with nowhere to go: not authorable (defineStackhas nofeatureskey; strict parsing strips it), not registered, not read by any engine. The platform skill even documented it as living only on the removed descriptor.The live surfaces (runtime configuration, not authored metadata):
feature_flagssettings manifest (@objectstack/service-settings, ADR-0007) — org-tunableai_enabled/beta_*, env-overridable viaOS_FEATURE_FLAGS_*PUBLIC_AUTH_FEATURESregistry +requiresFeaturesugar (unchanged, live)GET /api/v1/discoveryfor runtime capability discoveryChanges
feature.zod.ts+feature.test.ts; kernel index export dropped with a removal note (house pattern); manifest keyskernel/FeatureFlag+kernel/FeatureStrategydropped;PROTOCOL_MAP.mdrow dropped;SKILL_MAPentry dropped and skill references regenerated.references/kernel/feature.mdxremoved by regeneration; hand-written quick-reference row removed; the platform skill's Feature Flags section rewritten to point at the settings surface;public-auth-features.ts"not to be confused" comment updated.minorper launch-window policy) carries the removed-shape → settings-manifest migration table.Verification
6663 spec tests green ·
tsc --noEmitclean ·check:docs/check:api-surface/check:skill-refs/check:skill-docs/check:react-blocks/check:skill-examplesall in sync · downstream-contract typecheck clean.Refs #1878, #3605.
🤖 Generated with Claude Code