fix(auth): spell isLikelyEmail ASCII guard with printable bounds (no control char) - #3613
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
documentation
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 9 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
…control char) Mirror the objectui hygiene fix: `[^\x20-\x7e]` instead of `[^\x00-\x7f]` so the regex literal carries no control character (eslint no-control-regex). Same semantics — anything outside printable ASCII fails the email pre-filter. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny hygiene follow-up to the merged #3572 (framework#3566).
The non-ASCII guard added there was written as
[^\x00-\x7f], whose regex literal embeds a control character (\x00) — flagged by eslintno-control-regex. Rewrite as[^\x20-\x7e]:isPlausibleEmail, keeping the two implementations spelled the same.Pure cleanup;
admin-user-endpoints.test.ts(non-ASCII rejection cases) stays green.🤖 Generated with Claude Code