fix(service-settings): complete zh-CN coverage for auth/sms/ai settings (objectui#2851 P1)#3598
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 6 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
The auth, sms and ai manifests grew new groups and fields (breach/complexity/ history/expiry password policy, anti-abuse, MFA, extra session controls, network allow-list; the whole SMS Delivery namespace; DeepSeek/DashScope/ Cloudflare/SiliconFlow/OpenRouter providers + conversation-title options) but the zh-CN bundle wasn't updated, so those settings rendered English under a Chinese UI (objectui#2851 P1). - Fill every missing zh-CN group title + field label/help for auth, sms, ai. - Add a coverage guard test that pins zh-CN to full title/group/key coverage of every built-in settings manifest (option labels excluded — several are codes/format specimens that must not be translated). localization option labels (timezones/currencies/format specimens) remain a tracked follow-up; ja-JP / es-ES parity likewise. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ctui#2851 P1) Follow-up to the zh-CN auth/sms/ai fix: - zh-CN: translate the remaining localization option labels (timezone, locale, date/number format, currency, fiscal-year-start) — the settings bundle is now 100% covered, options included. - ja-JP / es-ES: bring both to full structural parity — extend auth (policy / anti-abuse / MFA / extra session controls / network) and ai (DeepSeek / DashScope / Cloudflare / SiliconFlow / OpenRouter + conversation titles), and add the previously-missing sms, company and localization namespaces. - Generalize the coverage guard to all three shipped non-English locales (renamed zh-CN.coverage.test.ts → settings-translation-coverage.test.ts). Package suite: 12 files / 175 tests pass (31 coverage assertions). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Complete zh-CN coverage for the auth / sms / ai built-in settings manifests. These manifests grew new groups and fields but the zh-CN translation bundle wasn't updated, so those settings rendered English under a Chinese UI.
Part of objectstack-ai/objectui#2851 (P1).
Changes
packages/services/service-settings/src/translations/zh-CN.ts— fill every missing group title + field label/help for:anti_abuse(lockout + rate-limit),multi_factor(MFA + grace), extra session controls (idle / absolute / concurrent),networkallow-list.SMS Deliverynamespace (provider select + Aliyun + Twilio groups/keys, test action).Plus
zh-CN.coverage.test.ts— a guard that pins zh-CN to full title/group/key coverage of every built-in settings manifest, so a future manifest addition can't silently regress into English. Dropdown option labels are intentionally excluded (some are codes / format specimens likedate_format= "YYYY-MM-DD" that must not be translated).Test
pnpm --filter @objectstack/service-settings test→ 12 files / 155 tests pass, including the new coverage guard and the manifest schema-parse tests.Follow-ups (not in this PR)
localizationoption labels (timezones / currencies / format specimens) — low value, several are codes.ja-JP/es-ESparity — currently sparser than zh-CN (missing whole groups).🤖 Generated with Claude Code