chore: refresh the vendored console to 2cb8d78e24ad + fix the refresh bump type (#3528)#3558
Merged
Merged
Conversation
… bump type (#3528) `@objectstack/console` ships a PREBUILT objectui SPA pinned by `.objectui-sha`, so a merged objectui fix is not live for anyone until that pin moves — the release pipeline clones objectui at the pin, builds it, and publishes the dist alongside the framework. The screen-flow fixes for #3528 landed in objectui (#2830, #2833) and were stranded there. This bumps the pin from cf2d56e32a11 to 2cb8d78e24ad so they ship, along with everything else merged frontend-side since the last refresh. Also fixes the bump-type detection in scripts/bump-objectui.sh, which decides whether a refresh is a minor or a patch. It tested the range with `git log --format=%s A..B | grep -qiE '^feat'`, but under `set -o pipefail` `grep -q` exits on the first match and the still-writing `git log` takes SIGPIPE, so the pipeline returned 141 and the test ALWAYS fell to the else branch. Every refresh was silently stamped `patch`, feature ranges included — this range has 20+ `feat` commits and was about to be stamped `patch` too. Counting with `grep -c` drains the input, so there is no signal and the count is truthful. Verified: with the fix the same invocation now writes `"@objectstack/console": minor`. `check:console-sha` passes (no dist in this checkout — nothing to drift against); the pinned commit is objectui `main`, which its own CI builds on every PR. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LX9ut3MK3KykE11S9bJmv5
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
os-zhuang
marked this pull request as ready for review
July 27, 2026 05:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ships the #3528 screen-flow fixes to actual users, and fixes a silent bug in the refresh tooling found while doing it.
Why this is needed
@objectstack/consolepublishes a prebuilt objectui SPA pinned by.objectui-sha: the release pipeline clones objectui at that commit, builds it, and ships the dist alongside the framework. So a merged objectui fix reaches nobody until the pin moves.The screen-flow fixes for #3528 landed in objectui (objectui#2830, objectui#2833) and were stranded there. This is not hypothetical — it is the exact trap I hit while investigating the issue: the console source was already correct while the running console at
/_consoleserved an older build, which is why the first repro looked like the bug was somewhere else entirely.Pin:
cf2d56e32a11→2cb8d78e24ad(objectuimain), which carries both screen-flow PRs plus everything else merged frontend-side since the last refresh. The generated changeset lists the full range.The tooling bug
scripts/bump-objectui.shpicks the changeset bump type —minorif the objectui range contains anyfeat, elsepatch. It tested that with:Under
set -o pipefail(line 32),grep -qexits on the first match, the still-writinggit logtakes SIGPIPE, and the pipeline returns 141. The test therefore always took the else branch: every refresh has been silently stampedpatch, feature ranges included. Demonstrated on this very range:Counting with
grep -cdrains the input, so there is no signal and the count is truthful. With the fix, the same invocation now writes"@objectstack/console": minor— as the script's own documented rule always intended.Test plan
OBJECTUI_ROOT=… scripts/bump-objectui.sh 2cb8d78e24ad --no-commitproduced both.objectui-shaand.changeset/console-2cb8d78e24ad.md.patch; after it,minor. Both observed.pnpm check:console-sha→ passes (no dist in this checkout, so nothing to drift against).main, which its own CI builds (Build & E2Eruns the console vite build,Bundle Analysisruns the fulltsc && vite buildand reported the entry at 28.0 KB / 350 KB budget) on every PR — so the pin is known-buildable without re-running the ~15-minute console build here.Note the changeset is
minorwhere recent console refreshes readpatch; that is the corrected behavior, not a deliberate escalation for this range.🤖 Generated with Claude Code
https://claude.ai/code/session_01LX9ut3MK3KykE11S9bJmv5
Generated by Claude Code