fix(spec): sync PROTOCOL_VERSION to 14.0.0 after the major release — main is red without it#2772
Merged
Merged
Conversation
The 14.0.0 Version Packages merge bumped package.json but the handshake constant still said 13.0.0, so protocol-version.test.ts fails on main and turns every open PR's Test Core red. Changesets cannot bump source constants — the protocol bump must accompany each major release. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012oLzaP8n7A3YKFmgaHWC8H
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
Contributor
📓 Docs Drift CheckNo hand-written docs reference the 0 changed package(s). ✅ |
os-zhuang
marked this pull request as ready for review
July 10, 2026 10:36
os-zhuang
pushed a commit
that referenced
this pull request
Jul 10, 2026
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012oLzaP8n7A3YKFmgaHWC8H
os-zhuang
added a commit
that referenced
this pull request
Jul 10, 2026
…sys_user, Holders/Permission Sets tabs on sys_position (#2770) * feat(ui): position assignment panels as pure SDUI — Positions tab on sys_user, Holders/Permission Sets tabs on sys_position Adds relationshipValueField (default 'id') to RecordRelatedListProps — the generic name-keyed-junction affordance (sys_user_position.position stores sys_position.name) used for both the list filter and the Add picker's parent-side value. sys_user detail gains a Positions tab (assign via picker storing the machine name, valueField: 'name'); new sys_position detail page ships Holders (relationshipValueField: 'name') and Permission Sets tabs, registered by plugin-security. All server rules (D12 delegated-admin gate, audience-anchor rejection) surface their denials in the Add dialog; ADR-0091 validity columns become plain column additions later. Zero bespoke React. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012oLzaP8n7A3YKFmgaHWC8H * ci: retrigger (spec DTS build died without error on runner — local full suite 6676/6676 green) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012oLzaP8n7A3YKFmgaHWC8H * ci: retrigger after main protocol-version fix (#2772) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012oLzaP8n7A3YKFmgaHWC8H --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unbreaks main. The 14.0.0 Version Packages merge (#2736) bumped
packages/spec/package.jsonto 14.0.0, but the ADR-0087 handshake constantPROTOCOL_VERSIONstill says13.0.0— soprotocol-version.test.ts(which asserts the two stay in lockstep) fails on main and turns every open PR's Test Core red (first observed on #2770, reproduced twice, confirmed on a clean checkout of latest main).PROTOCOL_VERSION'13.0.0'→'14.0.0'(one line)Process note: the changesets Version PR cannot bump source constants, so the protocol bump must accompany each major release — worth folding into the release checklist (or a small guard that runs in the Version PR's CI rather than only post-merge).
Verification
specprotocol-version.test.ts3/3metadata-core(handshake consumer) 100/100🤖 Generated with Claude Code
https://claude.ai/code/session_012oLzaP8n7A3YKFmgaHWC8H
Generated by Claude Code