Skip to content

fix(spec): PROTOCOL_VERSION 12→13 — restore package-major lockstep (unbreaks main) #2731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
os-zhuang wants to merge 1 commit into from
+14 −1
Closed

fix(spec): PROTOCOL_VERSION 12→13 — restore package-major lockstep (unbreaks main) #2731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .changeset/protocol-version-13.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
'@objectstack/spec': patch
---

fix(spec): bump `PROTOCOL_VERSION` to 13.0.0 — restore lockstep with the package major

The ADR-0090 P1 breaking wave took the platform to 13.0.0, but the protocol
constant (the value the `engines.protocol` handshake compares) stayed at
12.0.0, tripping the lockstep guard in `protocol-version.test.ts` and turning
`Test Core` red on main for every PR. Protocol 13 is semantically correct:
the P1 renames (`roles:` → `positions:`, kind `role`/`profile` → `position`,
no aliases) are exactly the kind of authorable-surface break the handshake
exists to refuse across majors.
2 changes: 1 addition & 1 deletion packages/spec/src/kernel/protocol-version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* Kept in lockstep with the package's own major; `protocol-version.test.ts`
* asserts it against `package.json` so the two cannot drift.
*/
export const PROTOCOL_VERSION = '12.0.0';
export const PROTOCOL_VERSION = '13.0.0';

/** The protocol major as an integer — the value the handshake compares. */
export const PROTOCOL_MAJOR: number = Number.parseInt(PROTOCOL_VERSION.split('.')[0]!, 10);