Skip to content

ci(release): restore blocking live-hotcrm smoke — v2 adoption shipped #2730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-zhuang merged 1 commit into from
Jul 10, 2026
+6 −17
Merged

ci(release): restore blocking live-hotcrm smoke — v2 adoption shipped #2730

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 6 additions & 17 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,18 +62,6 @@ jobs:
run: bash scripts/build-console.sh

- name: Downstream backward-compat smoke (live hotcrm)
# TEMPORARY (ADR-0090 v2 launch window) — advisory, not blocking.
# ADR-0090 P1 (#2697) removed the sharing recipients `role` /
# `role_and_subordinates` from @objectstack/spec with NO compatibility
# aliases (docs/adr/0090 D3 — a deliberate, launch-window break). The
# latest published hotcrm tag (v1.2.2) still authors those values, so
# this gate necessarily goes red on a break the spec took on purpose,
# and no adopting hotcrm release exists yet to bump HOTCRM_REF to. Keep
# the step running for signal, but don't let it block the v2 publish.
# RESTORE (make blocking again): once hotcrm ships a release adopting
# the v2 recipient vocabulary, bump HOTCRM_REF below to that tag and
# delete this `continue-on-error` line so a red here blocks publish.
continue-on-error: true
# Pre-publish gate (#2035): the about-to-publish @objectstack/spec must
# not break a real third-party consumer pinned to a published release.
# Clones objectstack-ai/hotcrm@${HOTCRM_REF}, installs it (published
Expand All @@ -82,11 +70,12 @@ jobs:
# The deterministic in-repo floor is @objectstack/downstream-contract;
# this is the live ceiling.
env:
# v1.2.1: hotcrm dropped the ObjectSchema `detail` block removed by
# ADR-0085 (hotcrm#423) — the intended break, explicitly digested
# downstream. Bump this ref whenever a deliberate spec surface
# removal ships a matching hotcrm release.
HOTCRM_REF: v1.2.2
# v2.0.0: hotcrm adopted the ADR-0090 Permission Model v2 vocabulary
# (role→position recipients, profiles removed, explicit OWD —
# hotcrm#438), closing the launch-window advisory period from #2719.
# Bump this ref whenever a deliberate spec surface removal ships a
# matching hotcrm release.
HOTCRM_REF: v2.0.0
run: bash scripts/downstream-smoke.sh

- name: Create Release Pull Request or Publish to npm
Expand Down
Loading