Skip to content

ci(release): make live-hotcrm downstream smoke advisory during ADR-0090 v2 launch window#2719

Merged
os-zhuang merged 1 commit into
mainfrom
claude/ci-errors-hdi319
Jul 9, 2026
Merged

ci(release): make live-hotcrm downstream smoke advisory during ADR-0090 v2 launch window#2719
os-zhuang merged 1 commit into
mainfrom
claude/ci-errors-hdi319

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

What

Marks the Release workflow's Downstream backward-compat smoke (live hotcrm) step continue-on-error: true so it runs for signal but no longer fails the job / blocks the publish during the ADR-0090 v2 launch window.

Why

The Release workflow is the only red check on main, and it has failed on every commit since ADR-0090 P1 (6d83431, #2697) — the last green Release run was the ADR-0090 docs commit (d8b6304).

Root cause: ADR-0090 P1 removed the sharing recipients role / role_and_subordinates from @objectstack/spec with no compatibility aliases (a deliberate, launch-window break — docs/adr/0090 D3, "the deprecated alias is not shipped"). The downstream-smoke gate clones the pinned hotcrm@v1.2.2, overlays the freshly-built spec, and typechecks it — and v1.2.2 (the latest published hotcrm tag, and hotcrm's main) still authors those recipients:

objectstack.config.ts(94,5): error TS2322: Type '{ type: "role"; value: string; }'
  is not assignable to type '{ type: "user" | "group" | "position" | "guest" | "unit_and_subordinates"; ... }'
objectstack.config.ts(95,5): Type '"role_and_subordinates"' is not assignable ... Did you mean '"unit_and_subordinates"'?

So the gate is red on a break the spec took on purpose, and there is no adopting hotcrm release to bump HOTCRM_REF to yet. Per the workflow's own convention (bump the ref when a deliberate spec removal ships a matching hotcrm release), the correct end-state requires a downstream hotcrm release first. Until then, this makes the gate advisory instead of blocking so the v2 publish pipeline is unblocked.

How

  • .github/workflows/release.yml: add continue-on-error: true to the live-hotcrm smoke step, with a TEMPORARY / RESTORE comment block documenting the launch-window rationale and the exact restore steps.
  • The step still executes and reports (visible warning) — no loss of signal.
  • Original gate documentation is left intact so restoring is a clean, minimal revert.

Restore condition

Once hotcrm ships a release adopting the v2 recipient vocabulary (roleposition, role_and_subordinatesunit_and_subordinates), bump HOTCRM_REF to that tag and delete the continue-on-error line so a red here blocks publish again.

Testing

  • release.yml validated with a YAML parser; the continue-on-error, env.HOTCRM_REF, and run keys parse as expected on the step.
  • No product code touched — CI workflow only.

🤖 Generated with Claude Code

https://claude.ai/code/session_016ZGeuMQ4SeuCR4uaiWTUX5


Generated by Claude Code

…90 v2 launch window

The Release workflow's "Downstream backward-compat smoke (live hotcrm)"
gate has been red on every main commit since ADR-0090 P1 (#2697), which
removed the sharing recipients `role` / `role_and_subordinates` from
@objectstack/spec with no compatibility aliases (docs/adr/0090 D3). The
latest published hotcrm tag (v1.2.2) still authors those recipients, so
the gate necessarily fails on a break the spec took deliberately, and no
adopting hotcrm release exists yet to bump HOTCRM_REF to.

Mark the step continue-on-error so it keeps running for signal but no
longer blocks the v2 publish. Restore hard-blocking (drop the flag and
bump HOTCRM_REF) once hotcrm ships a release on the v2 recipient
vocabulary.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016ZGeuMQ4SeuCR4uaiWTUX5
@vercel

vercel Bot commented Jul 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
spec Ready Ready Preview, Comment Jul 9, 2026 10:57am

Request Review

@os-zhuang
os-zhuang marked this pull request as ready for review July 9, 2026 11:05
@os-zhuang
os-zhuang merged commit b586b12 into main Jul 9, 2026
15 checks passed
@os-zhuang
os-zhuang deleted the claude/ci-errors-hdi319 branch July 9, 2026 11:05
os-zhuang added a commit that referenced this pull request Jul 10, 2026
… (hotcrm v2.0.0) (#2730)

Closes the ADR-0090 launch-window advisory period from #2719: hotcrm
v2.0.0 adopts the v2 vocabulary (hotcrm#438), so HOTCRM_REF bumps to
that tag and the continue-on-error escape hatch is deleted — a red
smoke blocks publish again.

DO NOT MERGE before the hotcrm v2.0.0 tag exists.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants