ci(release): make live-hotcrm downstream smoke advisory during ADR-0090 v2 launch window#2719
Merged
Conversation
…90 v2 launch window The Release workflow's "Downstream backward-compat smoke (live hotcrm)" gate has been red on every main commit since ADR-0090 P1 (#2697), which removed the sharing recipients `role` / `role_and_subordinates` from @objectstack/spec with no compatibility aliases (docs/adr/0090 D3). The latest published hotcrm tag (v1.2.2) still authors those recipients, so the gate necessarily fails on a break the spec took deliberately, and no adopting hotcrm release exists yet to bump HOTCRM_REF to. Mark the step continue-on-error so it keeps running for signal but no longer blocks the v2 publish. Restore hard-blocking (drop the flag and bump HOTCRM_REF) once hotcrm ships a release on the v2 recipient vocabulary. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016ZGeuMQ4SeuCR4uaiWTUX5
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
os-zhuang
marked this pull request as ready for review
July 9, 2026 11:05
This was referenced Jul 10, 2026
os-zhuang
added a commit
that referenced
this pull request
Jul 10, 2026
… (hotcrm v2.0.0) (#2730) Closes the ADR-0090 launch-window advisory period from #2719: hotcrm v2.0.0 adopts the v2 vocabulary (hotcrm#438), so HOTCRM_REF bumps to that tag and the continue-on-error escape hatch is deleted — a red smoke blocks publish again. DO NOT MERGE before the hotcrm v2.0.0 tag exists. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Marks the Release workflow's
Downstream backward-compat smoke (live hotcrm)stepcontinue-on-error: trueso it runs for signal but no longer fails the job / blocks the publish during the ADR-0090 v2 launch window.Why
The Release workflow is the only red check on
main, and it has failed on every commit since ADR-0090 P1 (6d83431, #2697) — the last green Release run was the ADR-0090 docs commit (d8b6304).Root cause: ADR-0090 P1 removed the sharing recipients
role/role_and_subordinatesfrom@objectstack/specwith no compatibility aliases (a deliberate, launch-window break —docs/adr/0090D3, "the deprecated alias is not shipped"). The downstream-smoke gate clones the pinnedhotcrm@v1.2.2, overlays the freshly-built spec, and typechecks it — and v1.2.2 (the latest published hotcrm tag, and hotcrm'smain) still authors those recipients:So the gate is red on a break the spec took on purpose, and there is no adopting hotcrm release to bump
HOTCRM_REFto yet. Per the workflow's own convention (bump the ref when a deliberate spec removal ships a matching hotcrm release), the correct end-state requires a downstream hotcrm release first. Until then, this makes the gate advisory instead of blocking so the v2 publish pipeline is unblocked.How
.github/workflows/release.yml: addcontinue-on-error: trueto the live-hotcrm smoke step, with aTEMPORARY/RESTOREcomment block documenting the launch-window rationale and the exact restore steps.Restore condition
Once hotcrm ships a release adopting the v2 recipient vocabulary (
role→position,role_and_subordinates→unit_and_subordinates), bumpHOTCRM_REFto that tag and delete thecontinue-on-errorline so a red here blocks publish again.Testing
release.ymlvalidated with a YAML parser; thecontinue-on-error,env.HOTCRM_REF, andrunkeys parse as expected on the step.🤖 Generated with Claude Code
https://claude.ai/code/session_016ZGeuMQ4SeuCR4uaiWTUX5
Generated by Claude Code