feat(i18n): localize accessibility labels#130
Merged
Conversation
P4 (safe part) of the i18n sweep — the screen-reader `accessibilityLabel`s that
were still hardcoded English.
New `a11y` namespace (goBack, clearSearch, dismiss, toolActivity, flowDiagram,
stateMachineDiagram, loading{List,Dashboard,Detail,Form}); reuses common.{edit,
delete,close} and ai.reasoning for the rest.
Wired: ScreenHeader (back — every screen), SearchBar (clear), BottomSheet
(close), Toast (dismiss), ToolInvocations, Reasoning, SwipeableRow (edit/delete),
FlowViewer + StateMachineViewer (diagrams), and the four loading skeletons.
Toast/StateMachineViewer alias the hook to `tr` to avoid shadowing their
existing `t` callback params.
All three locales at full key parity; tsc + lint clean, full suite 1337 passing.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i18n P4 (safe part) — accessibility labels
The screen-reader
accessibilityLabels that were still hardcoded English.New
a11ynamespace (goBack, clearSearch, dismiss, toolActivity, flowDiagram, stateMachineDiagram, loading{List,Dashboard,Detail,Form}); reusescommon.{edit,delete,close}andai.reasoningfor the rest.Wired: ScreenHeader (back — every screen), SearchBar (clear), BottomSheet (close), Toast (dismiss), ToolInvocations, Reasoning, SwipeableRow (edit/delete), FlowViewer + StateMachineViewer (diagrams), and the four loading skeletons. Toast / StateMachineViewer alias the hook to
trto avoid shadowing their existingtmap-callback params.All three locales at full key parity; tsc + lint clean, full suite 1337 passing.
Not included — RTL (genuinely blocked)
The audit's last item, full Arabic RTL layout, is not in this PR. It needs:
expo-updatesnorreact-native-restartis installed, soI18nManager.forceRTL()can't take effect on native without adding a native dep + rebuild.marginLeft/Right,flex-row, and absolute-position assumptions.That's a sizable, riskier feature on its own; flagging rather than half-applying it.
🤖 Generated with Claude Code