fix(#984): speed up incorrect-bytes-format lint#1017
Open
ext11n7 wants to merge 2 commits into
Open
Conversation
f916ae6 to
70aef89
Compare
Contributor
Author
Member
|
@volodya-lombrozo take a look please |
|
@ext11n7 It is not a good idea to name Git branches the way you named this one: " |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR speeds up the
incorrect-bytes-formatlint.The main optimization is in
incorrect-bytes-format.xsl:onodes onlystring-join(...)callsWhy
The lint was spending too much time scanning nodes and validating byte strings in a costly way during benchmark runs.
This change keeps the behavior the same while reducing the amount of work done per matched object.
Validation
incorrect-bytes-formatbecame noticeably faster than before