fix(#978): speed up bytes-without-data lint#1016
Open
ext11n7 wants to merge 2 commits into
Open
Conversation
b5839e8 to
2f23aa5
Compare
2f23aa5 to
b28283f
Compare
Contributor
Author
Member
|
@volodya-lombrozo check it please |
|
@ext11n7 It is not a good idea to name Git branches the way you named this one: " |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Optimizes the
bytes-without-datalint by replacing expensive XPath predicates with a cheaper structural check.Instead of evaluating
eo:has-data()andeo:abstract()for every matching node, the lint now selects only nodes that:Φ.bytes@baseWhy
The previous XPath was too slow on large XMIR files.
On the benchmark source set,
bytes-without-dataimproved onXXLfrom138msto69ms, which brings it below the100msthreshold from the issue.Validation