Skip to content

go/oasis-node: Bump default pruning config to 250_000 versions#6449

Merged
martintomazic merged 1 commit intomasterfrom
martin/feature/bump-default-pruning-cfg
Jan 27, 2026
Merged

go/oasis-node: Bump default pruning config to 250_000 versions#6449
martintomazic merged 1 commit intomasterfrom
martin/feature/bump-default-pruning-cfg

Conversation

@martintomazic
Copy link
Copy Markdown
Contributor

@martintomazic martintomazic commented Jan 26, 2026

Let's use a sane defaults for the pruning config (context).

Update defaults to 250_000 versions, so that node has enough consensus and runtime state to create at least two chekpoints if the checkpoint interval is 100_000. At the same time this is still far from the number of versions, that makes Sapphire pruning prohibitively slow.

Follow-ups

  • In the future to make code more robust we might consider prune handlers that prevent pruning past pending checkpoint creation. (out of scope).
  • Enable checkpoint creation by default to ensure long term data availability of the checkpoints.
  • Probably we should enable pruning by default.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 26, 2026

Deploy Preview for oasisprotocol-oasis-core canceled.

Name Link
🔨 Latest commit 461ca09
🔍 Latest deploy log https://app.netlify.com/projects/oasisprotocol-oasis-core/deploys/69777e8c43c97a0008d6bacd

@martintomazic
Copy link
Copy Markdown
Contributor Author

Bumping default configs might break configs that rely on the default values, so should the changelog be breaking? In practice the default value of 600 was already not practical.

Update defaults to 250_000 versions, so that node has enough
consensus and runtime state to create at least two chekpoints
if the checkpoint interval is 100_000. At the same time this
is still far from the number of versions, that makes Sapphire
pruning prohibitively slow.
@martintomazic martintomazic force-pushed the martin/feature/bump-default-pruning-cfg branch from b979c28 to 461ca09 Compare January 26, 2026 14:47
@martintomazic
Copy link
Copy Markdown
Contributor Author

CI was green meaning no e2e test relied on this defaults. :)

@martintomazic martintomazic marked this pull request as ready for review January 26, 2026 14:48
@martintomazic martintomazic self-assigned this Jan 27, 2026
@martintomazic martintomazic merged commit 209fcc9 into master Jan 27, 2026
5 checks passed
@martintomazic martintomazic deleted the martin/feature/bump-default-pruning-cfg branch January 27, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants