go/oasis-node: Bump default pruning config to 250_000 versions#6449
Merged
martintomazic merged 1 commit intomasterfrom Jan 27, 2026
Merged
go/oasis-node: Bump default pruning config to 250_000 versions#6449martintomazic merged 1 commit intomasterfrom
martintomazic merged 1 commit intomasterfrom
Conversation
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
Contributor
Author
|
Bumping default configs might break configs that rely on the default values, so should the changelog be breaking? In practice the default value of |
Update defaults to 250_000 versions, so that node has enough consensus and runtime state to create at least two chekpoints if the checkpoint interval is 100_000. At the same time this is still far from the number of versions, that makes Sapphire pruning prohibitively slow.
b979c28 to
461ca09
Compare
Contributor
Author
|
CI was green meaning no e2e test relied on this defaults. :) |
kostko
approved these changes
Jan 26, 2026
peternose
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's use a sane defaults for the pruning config (context).
Update defaults to 250_000 versions, so that node has enough consensus and runtime state to create at least two chekpoints if the checkpoint interval is 100_000. At the same time this is still far from the number of versions, that makes Sapphire pruning prohibitively slow.
Follow-ups