Skip to content

phase3: send base_file/rev_file in payload; log review page URL #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reuvenharrison wants to merge 1 commit into
base: main
Choose a base branch
from
Open

phase3: send base_file/rev_file in payload; log review page URL #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pr-comment/entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,10 @@ payload=$(jq -n \
--argjson pr "$pr_number" \
--arg sha "$GITHUB_SHA" \
--arg base_ref "$GITHUB_BASE_REF" \
--arg base_file "$base" \
--arg rev_file "$revision" \
--argjson changes "$changes" \
'{github: {token: $token, owner: $owner, repo: $repo, pull_number: $pr, head_sha: $sha, base_ref: $base_ref}, changes: $changes}')
'{github: {token: $token, owner: $owner, repo: $repo, pull_number: $pr, head_sha: $sha, base_ref: $base_ref}, base_file: $base_file, rev_file: $rev_file, changes: $changes}')

# POST to oasdiff-service
response=$(curl -s -w "\n%{http_code}" -X POST \
Expand All @@ -77,7 +79,11 @@ body=$(echo "$response" | sed '$d')

if [ "$http_code" -ge 200 ] && [ "$http_code" -lt 300 ]; then
comment_url=$(echo "$body" | jq -r '.comment_url // empty')
report_url=$(echo "$body" | jq -r '.report_url // empty')
echo "PR comment posted: $comment_url"
if [ -n "$report_url" ]; then
echo "Review page: $report_url"
fi
else
echo "ERROR: oasdiff-service returned HTTP $http_code" >&2
echo "$body" >&2
Expand Down
Loading