Skip to content

fix(files): ensure BufWinEnter after :edit <dir> #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abeldekat wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −2
Open

fix(files): ensure BufWinEnter after :edit <dir> #2467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lua/mini/files.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1381,7 +1381,9 @@ H.create_autocommands = function(config)
vim.cmd('silent! autocmd! FileExplorer *')
vim.cmd('autocmd VimEnter * ++once silent! autocmd! FileExplorer *')

au('BufEnter', '*', H.track_dir_edit, 'Track directory edit')
-- - Use `nested` to allow other events (`BufWinEnter` for 'mini.clue')
local opts = { nested = true, group = gr, callback = H.track_dir_edit, desc = 'Track directory edit' }
vim.api.nvim_create_autocmd('BufEnter', opts)
end

au('VimResized', '*', MiniFiles.refresh, 'Refresh on resize')
Expand Down
13 changes: 12 additions & 1 deletion tests/test_files.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6324,6 +6324,13 @@ T['Default explorer']['works in `:tabfind .`'] = function()
end

T['Default explorer']['handles close without opening file'] = function()
child.lua([[
_G.log = {}
vim.api.nvim_create_autocmd('BufWinEnter', {
callback = function(data) table.insert(_G.log, data.buf) end,
})
]])

local validate = function()
local buf_name = child.api.nvim_buf_get_name(0)
child.cmd('edit ' .. test_dir_path)
Expand All @@ -6334,8 +6341,12 @@ T['Default explorer']['handles close without opening file'] = function()
eq(#child.api.nvim_list_bufs(), 1)
end

-- Should hide "directory buffer" if there is no alternative buffer
-- Should delete "directory buffer" if there is no alternative buffer
validate()
-- Expect `BufWinEnter` on the buffer replacing "directory buffer"
-- This is needed for 'mini.clue' to attach
eq(#child.lua_get('_G.log'), 3)
eq(child.lua_get('_G.log')[3], child.api.nvim_get_current_buf())

-- Should smartly (preserving layout) delete "directory buffer"
local win_id_other = child.api.nvim_get_current_win()
Expand Down
Loading