Skip to content

Automatic release on push#3

Merged
seanbudd merged 19 commits intonvaccess:mainfrom
nvdaes:automaticRelease
Apr 1, 2026
Merged

Automatic release on push#3
seanbudd merged 19 commits intonvaccess:mainfrom
nvdaes:automaticRelease

Conversation

@nvdaes
Copy link
Copy Markdown

@nvdaes nvdaes commented Mar 30, 2026

Related issue

Requested in nvaccess/AddonTemplate#1

Summary

This creates a release when pushing to the main branch, uploading the l10nUtil.exe as an asset.

Additional note

I've included dependency updates from dependabot. @seanbudd , we can revert uv.lock if you want.

  • We use the ncipollo/release action since I find it more updated than other similar actions and it uses node24.
    See

https://github.com/nvdaes/nvdaL10n/actions/runs/23759060888

Copilot AI review requested due to automatic review settings March 30, 2026 17:50
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an automated GitHub Actions release pipeline that builds the Windows executable on pushes to main, publishes it as a GitHub Release, and updates Python dependencies via uv.lock.

Changes:

  • Bump requests and urllib3 in uv.lock.
  • Make buildExecutable.yaml reusable via workflow_call.
  • Add automaticRelease.yaml workflow to build and publish a release on push to main.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

File Description
uv.lock Updates locked dependency versions for requests and urllib3.
.github/workflows/buildExecutable.yaml Adds workflow_call so it can be invoked as a reusable workflow.
.github/workflows/automaticRelease.yaml New workflow that calls the build workflow, downloads the artifact, and creates/updates a release.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/automaticRelease.yaml Outdated
Comment thread .github/workflows/buildExecutable.yaml
Comment thread .github/workflows/automaticRelease.yaml Outdated
nvdaes and others added 2 commits March 30, 2026 20:31
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@nvdaes
Copy link
Copy Markdown
Author

nvdaes commented Mar 30, 2026

@copilot, I've addressed your feedback. Let me know if you have more comments.

Comment thread .github/workflows/automaticRelease.yaml Outdated
Comment thread .github/workflows/automaticRelease.yaml Outdated
Comment thread uv.lock
@nvdaes
Copy link
Copy Markdown
Author

nvdaes commented Apr 1, 2026

pre-commit.ci run

@nvdaes
Copy link
Copy Markdown
Author

nvdaes commented Apr 1, 2026

pre-commit.ci run

@nvdaes
Copy link
Copy Markdown
Author

nvdaes commented Apr 1, 2026

@seanbudd this is ready for review.

Copy link
Copy Markdown
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks

Comment thread pyproject.toml Outdated
nvdaes and others added 4 commits April 1, 2026 06:14
@nvdaes
Copy link
Copy Markdown
Author

nvdaes commented Apr 1, 2026

@seanbudd I think that all is done.

@seanbudd seanbudd merged commit 358c700 into nvaccess:main Apr 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants