Skip to content

Fixes remaining issues for pr #19713#19902

Merged
seanbudd merged 35 commits intonvaccess:masterfrom
Emil-18:UIAStateFix
Apr 7, 2026
Merged

Fixes remaining issues for pr #19713#19902
seanbudd merged 35 commits intonvaccess:masterfrom
Emil-18:UIAStateFix

Conversation

@Emil-18
Copy link
Copy Markdown
Contributor

@Emil-18 Emil-18 commented Apr 3, 2026

Link to issue number:

None

Summary of the issue:

Description of user facing changes:

When a COM error is raised in UIA._get_states, results that makes more sense are reported to the user, for example, when the enabeled state failes, the object will not be reported as disabled

Description of developer facing changes:

None

Description of development approach:

Testing strategy:

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

Emil-18 and others added 30 commits August 1, 2025 21:37
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
@Emil-18 Emil-18 requested a review from a team as a code owner April 3, 2026 14:37
@Emil-18 Emil-18 requested a review from SaschaCowley April 3, 2026 14:37
@OzancanKaratas
Copy link
Copy Markdown
Collaborator

@Emil-18, history is not clean. Please do the following:

  1. Backup the files you changed.
  2. Hard reset your branch to the latest commit of nvaccess/nvda/master.
  3. Copy the backed-up files to their original locations and create a commit.
  4. Force push the changes in your branch.

If you are new to Git, I can do this for you. If you want this, you'll need to grant me access to your repository.

@seanbudd
Copy link
Copy Markdown
Member

seanbudd commented Apr 7, 2026

history doesn't matter much, we perform squash commits

@seanbudd seanbudd merged commit 71c34b0 into nvaccess:master Apr 7, 2026
41 checks passed
@github-actions github-actions bot added this to the 2026.2 milestone Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants