Skip to content

Fix Scintilla crash#19833

Merged
SaschaCowley merged 2 commits intobetafrom
scintillaCrash
Apr 7, 2026
Merged

Fix Scintilla crash#19833
SaschaCowley merged 2 commits intobetafrom
scintillaCrash

Conversation

@SaschaCowley
Copy link
Copy Markdown
Member

Link to issue number:

Fixes #19729

Summary of the issue:

NVDA occasionally causes Notepad++ (and likely other Scintilla-based editors) to crash.

Description of user facing changes:

The crash should no longer occur.

Description of developer facing changes:

None

Description of development approach:

Return early if end < start in ScintillaTextInfo._getTextRange.

Testing strategy:

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@github-actions github-actions bot requested a deployment to snapshot March 24, 2026 04:22 Abandoned
@SaschaCowley SaschaCowley marked this pull request as ready for review April 7, 2026 00:36
@SaschaCowley SaschaCowley requested a review from a team as a code owner April 7, 2026 00:36
@SaschaCowley SaschaCowley requested a review from seanbudd April 7, 2026 00:36
Comment thread source/NVDAObjects/window/scintilla.py Outdated
Co-authored-by: Sean Budd <sean@nvaccess.org>
@SaschaCowley SaschaCowley enabled auto-merge (squash) April 7, 2026 02:05
@seanbudd seanbudd added this to the 2026.1 milestone Apr 7, 2026
@SaschaCowley SaschaCowley disabled auto-merge April 7, 2026 03:14
@SaschaCowley SaschaCowley merged commit 9daac1b into beta Apr 7, 2026
105 of 111 checks passed
@SaschaCowley SaschaCowley deleted the scintillaCrash branch April 7, 2026 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants