fix up pre-commit for xliff files#19426
Merged
SaschaCowley merged 10 commits intobetafrom Jan 18, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a pre-commit configuration issue that prevents adding new languages to NVDA from Crowdin. The check-added-large-files hook was blocking commits of large xliff translation files.
- Updates pre-commit config to exclude xliff files from the large file size check
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
seanbudd
added
the
conceptApproved
run uv lock --upgrade
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
seanbudd
commented
Jan 16, 2026
5 tasks
seanbudd
added a commit
that referenced
this pull request
Jan 19, 2026
was blocked by #19426 and #19458 Summary of the issue: #19458 introduced Cambodian, but we need to document it's support in NVDA Additionally, unit tests are temporarily broken by #19458 causing an issue, with python/cpython#123853 as the root cause Description of user facing changes: Document cambodian support Description of developer facing changes: None Description of development approach: Introduced _LCIDS_TO_TRANSLATED_LOCALES_OVERRIDES in languageHandler.py to correctly map the Windows LCID for Khmer (Cambodian), addressing upstream issues in Python's locale mapping. [1] [2] Refactored type annotations throughout languageHandler.py to use modern Python syntax (e.g., str | None instead of Optional[str], list[str] instead of List[str]). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
Adding new languages to NVDA from Crowdin causes pre-commit to fail, as it commits large xliff files.
Failed job: https://github.com/nvaccess/nvda/actions/runs/20842477976/job/59879416174
Description of user facing changes:
None
Description of developer facing changes:
We can add new languages to NVDA via Crowdin
Description of development approach:
update pre-commit
Testing strategy:
Tested trying to commit a large xliff file locally
Known issues with pull request:
n/a
Code Review Checklist: